john-bodley commented on a change in pull request #4834: Load async sql lab
results early for Presto
URL:
https://github.com/apache/incubator-superset/pull/4834#discussion_r183947898
##########
File path: superset/views/core.py
##########
@@ -2304,14 +2304,15 @@ def results(self, key):
"""Serves a key off of the results backend"""
if not results_backend:
return json_error_response("Results backend isn't configured")
-
blob = results_backend.get(key)
if not blob:
return json_error_response(
'Data could not be retrieved. '
'You may want to re-run the query.',
status=410,
)
+ if utils.is_prefetch_key(key): # hack to not break when requesting
prefetch
Review comment:
Having the term "hack" in a comment is asking for trouble. Maybe we could
rethink this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
