john-bodley commented on a change in pull request #4587: [logs] Dropping dt
column
URL:
https://github.com/apache/incubator-superset/pull/4587#discussion_r184249512
##########
File path: superset/migrations/versions/30bb17c0dc76_.py
##########
@@ -0,0 +1,26 @@
+"""empty message
+
+Revision ID: 30bb17c0dc76
+Revises: f231d82b9b26
+Create Date: 2018-04-08 07:34:12.149910
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = '30bb17c0dc76'
+down_revision = 'f231d82b9b26'
+
+from datetime import date
+
+from alembic import op
+import sqlalchemy as sa
+
+
+def upgrade():
+ with op.batch_alter_table('logs') as batch_op:
+ batch_op.drop_column('dt')
Review comment:
@mistercrunch just to clarify what should have the logic been here? I'm
simply asking to learn.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
