mistercrunch commented on a change in pull request #4905: [wip][missing values]
Removing replacing missing values
URL:
https://github.com/apache/incubator-superset/pull/4905#discussion_r185045726
##########
File path: superset/viz.py
##########
@@ -961,7 +936,6 @@ def as_floats(field):
return d
def get_data(self, df):
- df = df.fillna(0)
Review comment:
Are we sure that this particular visualization handles null nicely?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
