john-bodley commented on issue #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#issuecomment-385464671 @mistercrunch this PR is very much WIP as I need to go through each visualization type and update the logic were necessary. At the moment I've only taken a pass at the box-plot visualization. The reason I put this PR out was to gain more context (like your comment around `' NULL'`) to better understand what the logic should be and what tests I should write. I think there is merit in having consistency between how data in rendered in SQL Lab and slices, i.e., there are inconsistencies [here](https://github.com/apache/incubator-superset/issues/3603#issuecomment-373280675) where SQL Lab reports `null` and slices report ` NULL` (with a leading whitespace which messes with alignment).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
