mistercrunch commented on issue #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#issuecomment-385468553 Glad you're taking this on! I've had some conversations with @betodealmeida about sorting some of this out. I'm taking a tangent here thinking about NULL handling in time series. Users may want or expect a set of behaviors: * break the line, restart it on the other side (highcharts does this I think) * replace with 0 * link the line across both sides of the null Option 1 is arguably the best visual representation of what is happening, but as far as I know NVD3 doesn't do this well (maybe it didn't in the past but does now...) Option 2 makes it pretty clear that data is missing, though clearly NULL is not zero and that's somewhat wrong and ugly (steep diagonals) Option 3 is misleading, especially in the absence of markers, you may care and never know that data is missing. Recently we introduced ISO notation to `db_engine_specs` concept of time grain, which means Superset now knows about the time granularity. This can help us to time resampling and doing proper handling of missing values eventually. Eventually we could have a control section "Handling NULLs" this and offering all the needed options.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
