williaster commented on issue #4893: add sticky to sidepane URL: https://github.com/apache/incubator-superset/pull/4893#issuecomment-385475575 Going through the code now but some UI/UX thoughts (cc @elibrumbaugh): - the sidebar should always be the full height of the screen (see designs) - there should be no gap between the dashboard title header and the side bar - as a user scrolls down, the side bar should scroll up _until_ it hits the top of the screen, at which point it becomes sticky/fixed. as we discussed before, this might be done most easily with `react-sticky`. Also, will this approach also be compatible with making top-level tabs sticky? It should behave in the same way.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
