mistercrunch closed pull request #4918: Fix typos from linting URL: https://github.com/apache/incubator-superset/pull/4918
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/superset/db_engine_specs.py b/superset/db_engine_specs.py index e95b4d3928..ee8f632da4 100644 --- a/superset/db_engine_specs.py +++ b/superset/db_engine_specs.py @@ -1260,7 +1260,7 @@ class BQEngineSpec(BaseEngineSpec): def convert_dttm(cls, target_type, dttm): tt = target_type.upper() if tt == 'DATE': - return "{}'".format(dttm.strftime('%Y-%m-%d')) + return "'{}'".format(dttm.strftime('%Y-%m-%d')) return "'{}'".format(dttm.strftime('%Y-%m-%d %H:%M:%S')) @classmethod @@ -1291,7 +1291,7 @@ class ImpalaEngineSpec(BaseEngineSpec): def convert_dttm(cls, target_type, dttm): tt = target_type.upper() if tt == 'DATE': - return "{}'".format(dttm.strftime('%Y-%m-%d')) + return "'{}'".format(dttm.strftime('%Y-%m-%d')) return "'{}'".format(dttm.strftime('%Y-%m-%d %H:%M:%S')) @classmethod ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services