peter-stuart-turner commented on a change in pull request #4871: Add 
spider/radar chart 
URL: 
https://github.com/apache/incubator-superset/pull/4871#discussion_r185432767
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -2375,6 +2375,35 @@ def get_data(self, df):
         return result
 
 
+class SpiderRadarViz(BaseViz):
+    """
+    A spider / radar chart.
+    """
+
+    viz_type = 'spider_radar'
+    verbose_name = _('Spider Radar Diagram')
+    credits = (
+        '<a href=https://www.visualcinnamon.com/>Nadieh Bremer, Data Viz 
Expert</a>')
+    is_timeseries = False
+
+    def get_data(self, df):
 
 Review comment:
   Also, is this what you meant? I mean, adding a test here. I can't seem to 
find where to put tests for the javascript code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to