Right, adding a comment with a snapshot of the result at the time the vote ends is a simple solution.
Max On Fri, Dec 20, 2019 at 2:47 PM David Smith <dave.a.sm...@gmail.com> wrote: > If there is a way to "freeze" the reactions at the time the vote is > closed--maybe the bot adds a comment documenting the closing vote total and > sends an email--then there is no issue. It would only be a problem if a > vote could "pass" 5-4 or something, and then later a viewer would see 4 up > and 5 down votes with no additional record. > > On Fri, Dec 20, 2019 at 2:19 PM Maxime Beauchemin < > maximebeauche...@gmail.com> wrote: > > > I'm positive that edited comments are saved in history, and that > reactions > > have timestamps attached to them > > < > > > https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment > > >. > > Same goes for labels (effectively marking when voting starts/ends). > > > > [eventually] it would also be possible for our bot to: > > * catch and delete reactions when voting isn't open > > * send emails as needed > > * do accounting based on who's a PMC / committer / contributor > > (binding/non-binding). Hopefully Whimsy has some REST API we can hit to > get > > list of Github handles of committers / PMCs > > > > Max > > > > On Fri, Dec 20, 2019 at 2:07 PM David Smith <dave.a.sm...@gmail.com> > > wrote: > > > > > I think it would be vastly superior in terms of user-experience. I > think > > > the pushback would possibly be that email produces an immutable record > of > > > the vote and any conversation around it, whereas github votes can be > > > changed after the fact, comments may be edited, etc. > > > > > > It depends on what one is optimizing for, I suppose. > > > > > >
