Hi Maximilian,

Maximilian Odendahl wrote:
Hi Oliver,

Frank (FME) already investigated method <AttrChangedNotify(..)> and found out that calling <GetContentAtPos(..)> is not needed: <GetContentAtPos(..)> determines the content position via a screen position and than determines the content at this content position. The first part is not needed, because the content position is already known at this point.

 > const SwPostItField* GetPostItFieldAtCursor() const;


The same code is in SwEditWin::MouseMove as well, in this case not for the text cursor, but the mouse cursor (case 0: .......)

Although it wouldn't crash there I think, we could use the same new method there for consistency as well? (probably a little bit faster, too, but I guess not noticable anyway)

I do not think so.
In <SwEditWin::MouseMove(..)> you have the screen position of the mouse, which have to be converted into a content position (instance of SwPosition). Such a code is completely missing in new method <GetPostItFieldAtCursor()> and this was the code that causes the crash.

Thus, currently no change to <SwEditWin::MouseMove(..)>.

Regards, Oliver.

--
=======================================================================
Oliver-Rainer Wittmann (od) - OpenOffice.org Writer
OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

  • [sw-discussi... Maximilian Odendahl
    • Re: [sw... Maximilian Odendahl
    • Re: [sw... Oliver-Rainer Wittmann - Software Engineer - Sun Microsystems
      • Re:... Maximilian Odendahl
        • ... Oliver-Rainer Wittmann - Software Engineer - Sun Microsystems
          • ... Maximilian Odendahl
            • ... Oliver-Rainer Wittmann - Software Engineer - Sun Microsystems
              • ... Maximilian Odendahl

Reply via email to