Hi,
Maximilian Odendahl wrote:
Hi,

when I entered a comment in combination with change tracking into the modal dialog, I have the new string and the corresponding SwRedline, so I would have expected sth. like this(happening in SwTextShell::ExecField)

...
const SwRedline *pRedline = rSh.GetCurrRedline();
...
//now we get the string
...
pRedline->SetComment(sMsg);


But instead, this line is called:

......
rSh.SetRedlineComment(sMsg);
......

Can anyone explain to me why this is neccessary and how it works? All I understand that it is trying to find a redline with lcl_FindCurrRedline (which we actually already have it seems)and then attaching the comment.
at first pRedline is const. A second reason is that modifications at document elements should be done at a central place to take care for undo, document modification, notification etc. In the current case there is no undo ( which is bad ) but at least the document modification is done here (see sw/source/core/doc/docredln.cxx) .

Could this be completely removed or which part do I not understand here?
I'd not remove it.

Regards,
Oliver

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to