Hi MikHail, Thanks for your code review. I modified the code based on your suggestions. Please reivew the code changes. Thanks.
Best Regards, Steve Yin ------------------------------------- Symphony Common App and Performance IBM Corporation | Lotus Software Tel: 86-10-82454405 Email: [email protected] Notes: Bing BJ Yin/China/IBM Address: 2F, Ring Bldg. No.28 Building, Zhong Guan Cun Software Park, No. 8 Dong Bei Wang West Road, ShangDi, Haidian District, Beijing 100193, P.R.China From: Mikhail Voytenko <[email protected]> To: [email protected] Date: 2009-06-18 20:21 Subject: Re: [sw-discussion] The code for MS Word file encryption feature is committed to wordencryption CWS Hi, I have took a look to the changes and they look very good. There are some suggestions that would probably make the code better: - TempFile and SvFileStream are misused in wrtww8.cxx. The temporary files will not be removed since the streams are closed ( in SvMemoryStream destructors ) after the TempFile object is deleted. The correct way would be to get the streams using TempFile::GetStream(), it is even not necessary to remove the stream objects in this case since the TempFile destructor would do it. - The method SwWW8Writer::Write( SwPaM& rPaM, SfxMedium& rMed, const String* pFileName ) should call StgWriter::Write( rPaM, rMed, pFileName ) to use the designed benefits of the virtual method ( currently "Write( rPam, rMed.GetStorage(), pFileName )" is called directly. - The mpMedium should probably be set to NULL at the end of SwWW8Writer::Write() method. Currently it is not possible that the same reader is used twice, but if something like that happens the change would make the implementation safer. I have commited two small changes in the cws ( files wrtww8.cxx, wrtww8.hxx ) to let it be built in our environment, since the compiler warnings are not allowed there: - The order of member initializations in constructor of SwSS8Writer is adjusted. - Two virtual methods SwSS8Writer::Write() are introduced. Hope that helps. Best regards, Mikhail. On 06/17/09 09:31, Bing BJ Yin wrote: > Hi Mikhail, > > Thanks for taking the code review work. If you have any questions, please > do not hesitate to contact me. Thanks. > > > Best Regards, > > Steve Yin > ------------------------------------- > Symphony Common App and Performance > IBM Corporation | Lotus Software > Tel: 86-10-82454405 > Email: [email protected] > Notes: Bing BJ Yin/China/IBM > Address: 2F, Ring Bldg. No.28 Building, Zhong Guan Cun Software Park, No. > 8 Dong Bei Wang West Road, ShangDi, Haidian District, Beijing 100193, > P.R.China > > > > From: > Ming Fei Jia/China/i...@ibmcn > To: > [email protected] > Date: > 2009-06-12 00:46 > Subject: > Re: [sw-discussion] The code for MS Word file encryption feature is > committed to wordencryption CWS > > > > Good,thanks Mathias and Mikhail Voitenko. Looking forward to your review > comments. > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
