The patch is related to code I'm not very familiar with, so I will not be able to provide feedback. If you and Ruwan reviewed the patch, then we should commit it.
Andreas On Mon, Apr 20, 2009 at 11:15, Asankha C. Perera <[email protected]> wrote: > Hi Eric >> >> At the weekend I took some time to work on improving JMX and security >> support: https://issues.apache.org/jira/browse/SYNAPSE-526 >> >> Basically I incorporated the feedback received and had a look on Indikas >> quite flexible Security API he first introduced to datasources. As I'm >> already interested in using this, I first added a small implementation to >> support the default "JBoss way" of encryption (fixed passphrase) and other >> encoding. Additionally I enhanced the current CipherTool to be able to >> encrypt/decrypt using a simple passphrase. >> >> The next step I did was using the secret API also for JMX credentials. I >> therefore tried to come up with a default implementation which could be used >> to encrypt passwords also in other places without having to care to much >> about the internal security API offering a great flexibility which might not >> always be needed. >> >> I tested my changes for a lot of different scenarios, but I'm not sure >> whether I covered them all, as I likely even don't know all of them. >> >> So this is why I would like to ask anyone who could spend some minutes to >> review those changes/additions. > > I went though this change before the weekend, and it looked ok - I was > expecting feedback from Indika as this touches on the security / secret > stuff brought in recently.. but lets not delay it anymore as this touches a > few files, unless Ruwan / Andreas has any feedback not to commit.. > > cheers > asankha > > -- > Asankha C. Perera > AdroitLogic, http://adroitlogic.org > > http://esbmagic.blogspot.com > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
