Hi Ruwan,
hope you have fully recovered. While reviewing my patch, please also notice my comment on SYNAPSE-538. Regards, Eric ________________________________ From: Ruwan Linton [mailto:[email protected]] Sent: Friday, May 01, 2009 5:56 AM To: [email protected] Subject: Re: [jira] Updated: (SYNAPSE-536) Error while stoping the Synapse server Hi Eric, I was having a serious flue and was unable to work at all. I will have a look and will take care of this. Thanks, Ruwan On Thu, Apr 30, 2009 at 11:42 AM, Hubert, Eric <[email protected]> wrote: Ruwan, did you find time to review this patch? I’m a bit concerned the patch could get invalid due to other changes to some of the rather central classes and would need additional update effort. ________________________________ From: Hubert, Eric [mailto:[email protected]] Sent: Monday, April 27, 2009 9:16 PM To: [email protected] Subject: RE: [jira] Updated: (SYNAPSE-536) Error while stoping the Synapse server Hi all, Asankha, thanks for taking a high-level look on the patch. I would also feel much more comfortable if Ruwan could take an additional low-level look at the patch. ;-) I spent a couple of hours doing those changes spread of several days in which also other changes had been applied to the same classes, so I needed to update my working copy several times to catch up. I hope no change slipped through. I also did some method renaming and removed unnecessary indirections to make the code more readable. There is still room for improvements, but I wanted to get out the first chunk to not have to update too frequently due to parallel changes. Regards, Eric ________________________________ From: Asankha Perera [mailto:[email protected]] On Behalf Of Asankha C. Perera Sent: Monday, April 27, 2009 3:17 PM To: [email protected] Subject: Re: [jira] Updated: (SYNAPSE-536) Error while stoping the Synapse server Hi Eric I submitted my patch in a new JIRA (https://issues.apache.org/jira/browse/SYNAPSE-537 <https://issues.apache.org/jira/browse/SYNAPSE-537> ) as could not locate the existing issue. Maybe Asankha can help out. I hope someone finds time to review. Afterwards I will go through all the known issues on my list regarding the shutdown handling. Ruwan, if you can provide more details or stack trace I will be happily jump in and help once I find the time - next weekend at the latest. I've done a brief look at the changes, and they seem ok to me at a high level. I think Ruwan should ok this as well with the recent changes he has been doing on the stop/restart logic. thanks asankha -- Asankha C. Perera AdroitLogic, http://adroitlogic.org http://esbmagic.blogspot.com -- Ruwan Linton Senior Software Engineer & Product Manager; WSO2 ESB; http://wso2.org/esb WSO2 Inc.; http://wso2.org email: [email protected]; cell: +94 77 341 3097 blog: http://ruwansblog.blogspot.com
