Yes... got it. :-) I am going to add a set of tests for explicitly testing the locking behaviour.
BTW: locking is turned on by-default, no need to specify the transport.vfs.Locking parameter, unless it is disabled explicitly at the listener or sender configuration. Thanks, Ruwan On Sun, Aug 9, 2009 at 10:35 PM, Andreas Veithen <[email protected]>wrote: > They don't test locking explicitly, but they will fail randomly unless > the request file is created atomically (that is the case for the mock > client) or access to the request file is managed properly by some > locking strategy. > > Andreas > > On Sun, Aug 9, 2009 at 02:15, Ruwan Linton<[email protected]> wrote: > > > > > > On Sun, Aug 9, 2009 at 2:15 AM, <[email protected]> wrote: > >> > >> Author: veithen > >> Date: Sat Aug 8 20:45:50 2009 > >> New Revision: 802454 > >> > >> URL: http://svn.apache.org/viewvc?rev=802454&view=rev > >> Log: > >> SYNAPSE-565: If the VFS transport now supports locking, then we can > enable > >> the corresponding test cases :-) > > > > Cool, I will add some test cases for testing the locking behaviour as > well. > > I guess these tests doesn't explicitly tests the locking behaviour. > > > > Thanks, > > Ruwan > > > >> > >> Modified: > >> > >> > > synapse/trunk/java/modules/transports/core/vfs/src/test/java/org/apache/synapse/transport/vfs/VFSTransportTest.java > >> > >> Modified: > >> > synapse/trunk/java/modules/transports/core/vfs/src/test/java/org/apache/synapse/transport/vfs/VFSTransportTest.java > >> URL: > >> > http://svn.apache.org/viewvc/synapse/trunk/java/modules/transports/core/vfs/src/test/java/org/apache/synapse/transport/vfs/VFSTransportTest.java?rev=802454&r1=802453&r2=802454&view=diff > >> > >> > ============================================================================== > >> --- > >> > synapse/trunk/java/modules/transports/core/vfs/src/test/java/org/apache/synapse/transport/vfs/VFSTransportTest.java > >> (original) > >> +++ > >> > synapse/trunk/java/modules/transports/core/vfs/src/test/java/org/apache/synapse/transport/vfs/VFSTransportTest.java > >> Sat Aug 8 20:45:50 2009 > >> @@ -41,10 +41,6 @@ > >> // TODO: the VFS listener doesn't like reuseResources == true... > >> ManagedTestSuite suite = new > >> ManagedTestSuite(VFSTransportTest.class, false); > >> > >> - // The VFS sender doesn't create files atomically. This can > cause > >> the > >> - // listener to start reading files that are not completely > >> written yet. > >> - suite.addExclude("(&(client=axis)(endpoint=axis))"); > >> - > >> // Since VFS has no Content-Type header, SwA is not supported. > >> suite.addExclude("(test=AsyncSwA)"); > >> > >> > >> > > > > > > > > -- > > Ruwan Linton > > Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb > > WSO2 Inc.; http://wso2.org > > email: [email protected]; cell: +94 77 341 3097 > > blog: http://ruwansblog.blogspot.com > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Ruwan Linton Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb WSO2 Inc.; http://wso2.org email: [email protected]; cell: +94 77 341 3097 blog: http://ruwansblog.blogspot.com
