Hi Supun, On Mon, Nov 9, 2009 at 11:54 AM, Supun Kamburugamuva <[email protected]>wrote:
> Yes, I didn't want to say we need to apply that patch now. That patch > should have being applied a long time ago :). > That may be true. But there's a way to get things done from an open source community. I'm mentioning this here since you have been pointing a lot of fingers at the team lately. While we totally appreciate contributions from the community, please note that it is not a committer's duty or job to review submitted patches as soon as possible. We all try hard and save a few cycles to spend on Synapse work. It is only natural to get certain patches delayed for long periods. I know this by experience with a couple of other ASF projects as well. Sometimes we lose track of patches and JIRAs and the committers forget all about it after a few weeks. These issues usually resurface when we are about to do a release but as you know, there hasn't been any Synapse releases for a considerable period of time either. So there's obviously a ton of issues and patches accumulated over time which we will definitely review and commit before the 1.3 release. Meanwhile if someone is really eager to get a patch checked into the code base he can get the attention of the committers by bringing the discussion into the mailing list (that's what I did in this case). You can point out some valid usecases and emphasize the importance of fixing the issue in question. If that doesn't work just keep on writing to the list until somebody notices.... Thanks again for pointing out SYNAPSE-458. Please don't be dissapointed or discouraged just because some patches got delayed. They will be reviewed in time. Thanks, Hiranya > Thanks, > Supun.. > > > On Mon, Nov 9, 2009 at 11:52 AM, Hiranya Jayathilaka <[email protected] > > wrote: > >> >> >> On Mon, Nov 9, 2009 at 11:51 AM, Supun Kamburugamuva >> <[email protected]>wrote: >> >>> https://issues.apache.org/jira/browse/SYNAPSE-458 >>> >>> It only implemented support for boolean properties. >>> >> >> Thanks for pointing this out. But we should be able to do more than >> that.... I'll create a new JIRA and link that to SYNAPSE-458. >> >> Thanks, >> Hiranya >> >> >>> >>> Thanks, >>> Supun.. >>> >>> On Mon, Nov 9, 2009 at 11:39 AM, Hiranya Jayathilaka < >>> [email protected]> wrote: >>> >>>> >>>> >>>> On Mon, Nov 9, 2009 at 11:32 AM, Supun Kamburugamuva <[email protected] >>>> > wrote: >>>> >>>>> +1, >>>>> >>>>> Actually there was a patch to property mediator implementing this same >>>>> functionality. But I seemed nobody cared to look at it :) >>>>> >>>> >>>> What's the JIRA please? Does it implement support for all the above >>>> mentioned types? >>>> >>>> Thanks, >>>> Hiranya >>>> >>>> >>>>> >>>>> Thanks, >>>>> Supun.. >>>>> >>>>> >>>>> On Mon, Nov 9, 2009 at 10:58 AM, Hiranya Jayathilaka < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi Folks, >>>>>> >>>>>> Currently the property mediator sets all property values as strings. >>>>>> But in certain cases we will want to set property values of other types >>>>>> (integers, floats, OMElement etc). For instance when using certain JMS >>>>>> providers (eg: IBM MQ) this feature becomes a must, since they do not >>>>>> allow >>>>>> setting certain properties as strings. Such properties should be set with >>>>>> specific types. >>>>>> >>>>>> To solve this problem I would like to propose adding a new attribute >>>>>> to the property mediator. The new attribute, named 'type' will allow >>>>>> specifying a type for the parameter value. The property mediator will >>>>>> make >>>>>> sure that the value is properly cast into the specified type before >>>>>> setting >>>>>> the value. If the attribute is not specified the default type 'string' >>>>>> will >>>>>> be used so the existing behavior won't be affected. >>>>>> >>>>>> I have already done this modificataion for WSO2 ESB. I have >>>>>> implemented support for following types: >>>>>> >>>>>> - INTEGER >>>>>> - FLOAT >>>>>> - DOUBLE >>>>>> - BOOLEAN >>>>>> - LONG >>>>>> - SHORT >>>>>> - STRING >>>>>> - OM (to set OMElement parameters) >>>>>> >>>>>> If there are no objections, I would like to contribute this >>>>>> improvement to Synapse. So WDYT? Your comments and feedback are most >>>>>> appreciated. >>>>>> >>>>>> Thanks, >>>>>> Hiranya >>>>>> >>>>>> -- >>>>>> Hiranya Jayathilaka >>>>>> Software Engineer; >>>>>> WSO2 Inc.; http://wso2.org >>>>>> E-mail: [email protected]; Mobile: +94 77 633 3491 >>>>>> Blog: http://techfeast-hiranya.blogspot.com >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Software Engineer, WSO2 Inc >>>>> http://wso2.org >>>>> supunk.blogspot.com >>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Hiranya Jayathilaka >>>> Software Engineer; >>>> WSO2 Inc.; http://wso2.org >>>> E-mail: [email protected]; Mobile: +94 77 633 3491 >>>> Blog: http://techfeast-hiranya.blogspot.com >>>> >>> >>> >>> >>> -- >>> Software Engineer, WSO2 Inc >>> http://wso2.org >>> supunk.blogspot.com >>> >>> >>> >> >> >> -- >> Hiranya Jayathilaka >> Software Engineer; >> WSO2 Inc.; http://wso2.org >> E-mail: [email protected]; Mobile: +94 77 633 3491 >> Blog: http://techfeast-hiranya.blogspot.com >> > > > > -- > Software Engineer, WSO2 Inc > http://wso2.org > supunk.blogspot.com > > > -- Hiranya Jayathilaka Software Engineer; WSO2 Inc.; http://wso2.org E-mail: [email protected]; Mobile: +94 77 633 3491 Blog: http://techfeast-hiranya.blogspot.com
