[
https://issues.apache.org/jira/browse/SYNAPSE-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851530#action_12851530
]
Eric Hubert edited comment on SYNAPSE-622 at 3/30/10 7:37 PM:
--------------------------------------------------------------
Just two small questions to think about before committing:
1) Could this hide some other problem? Why is either the context not available
or has no attribute with the connection creation time?
2) Is the rest of the code just fine with an uninitilized connection creation
time or could this lead to misleading/wrong output/calculations later on?
Would be nice to have answers on both before committing the change although it
is definitely correct to be defensive in this area as no runtime issue in this
part should populate up the stack.
If there would be more logic one could even get a step further and implement a
fault barrier around the public interface which catches all exceptions and
ensures that message processing will not be affected no matter what aspect
fails within the connection (debug) tracing aspect.
was (Author: ehubert):
Just two small questions to think about before committing:
1) Could this hide some other problem? Why is either the context not available
or has no attribute with the connection creation time?
2) Is the rest of the code just fine with an uninitilized connection creation
time or could this lead to misleading/wrong output/calculations later on?
Would be nice to have answers on both before committing the change although it
is definitely correct to be defensive in this area as no runtime issue in this
part should populate up the stack.
If there would be more logic one could even get a step further and implement a
fault barrier around the public interface which catches all exceptions and
ensures that message processing will not be affected no matter what aspect
fails within the connection (debug) tracing apsect.
> NPE in ClientConnectionDebug.java:36 when running in a failover scenario
> -------------------------------------------------------------------------
>
> Key: SYNAPSE-622
> URL: https://issues.apache.org/jira/browse/SYNAPSE-622
> Project: Synapse
> Issue Type: Bug
> Components: Core
> Reporter: Rajika Kumarasiri
> Priority: Critical
> Fix For: 1.3
>
> Attachments: SYNAPSE-622.patch
>
>
> When I run sample #52 with one of the leaf endpoint being timeout, following
> NPE is thrown time to time. Once this is encountered that message is
> permanently lost. I'll upload a small patch which will fix the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
