Thanks for the feedback. I'll update the patch appropriately. Rajika
On Wed, Apr 28, 2010 at 10:31 PM, Ruwan Linton <[email protected]>wrote: > Also, please submit the patch via a JIRA. > > Thanks, > Ruwan > > > On Wed, Apr 28, 2010 at 10:27 PM, Ruwan Linton <[email protected]>wrote: > >> Rajika, >> >> This patch has an issue, where it pops the fault handler from the fault >> stack, ideally you should get the proxy from the synapse configuration and >> get the fault sequence from that and push into the fault stack of inMsgCtx. >> >> Otherwise, if there has been some other fault handler pushed, it will be >> set as the fault handler which is wrong. >> >> Thanks, >> Ruwan >> >> On Wed, Apr 28, 2010 at 7:29 PM, Rajika Kumarasiri <[email protected]>wrote: >> >>> Assume the following synapse configuration. >>> >>> <proxy name="StockQuoteProxy"> >>> <target faultSequence="myFaultHandler"> >>> <inSequence> >>> <!-- in sequence goes here --> >>> </inSequence> >>> <outSequence> >>> <!-- out sequence goes here --> >>> </outSequence> >>> </target> >>> <publishWSDL >>> uri="file:repository/conf/sample/resources/proxy/sample_proxy_1.wsdl"/> >>> </proxy> >>> >>> <sequence name="myFaultHandler"> >>> <!-- fault sequence --> >>> </sequence> >>> >>> It seems that the synapse ignores executing the fault handler >>> 'myFaultHandler' when an exception is thrown in outSequence of the proxy >>> definition. >>> By looking at the code I can see that the registered fault handler only >>> take effect in inSequence, reason is the registered fault handler only added >>> only into out message context. But when we define a fault handler for the >>> proxy it should handle both exceptions occurs in in sequence and out >>> sequence. >>> I fixed the problem by sharing the defined fault handler in, in message >>> context as well ( I have attached the diff). If you agree with the solution >>> I can provide this as patch. >>> >>> >>> Rajika >>> -- >>> http://rajikak.blogspot.com/ >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >> >> >> >> -- >> Ruwan Linton >> Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb >> WSO2 Inc.; http://wso2.org >> email: [email protected]; cell: +94 77 341 3097 >> blog: http://ruwansblog.blogspot.com >> > > > > -- > Ruwan Linton > Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb > WSO2 Inc.; http://wso2.org > email: [email protected]; cell: +94 77 341 3097 > blog: http://ruwansblog.blogspot.com > -- http://rajikak.blogspot.com/
