Doing the mediator API related changes I asked myself whether concrete mediators like FaultMediator should really widen the visibility of AbstractMediatorFactory#createSpecificMediator. At least some of Synapse built-in mediators change the visibility from protected to public. I did not check all of them. I don’t think this is generally a good idea as to my understanding “users” of any MediatorFactory implementation should always only call createMediator (which internally delegates to createSpecificMediator). Otherwise functionality from the AbstractMediatorFactory might be mistakenly bypassed.
Another small side-note AbstractMediatorFactory#createMediator’s JavaDoc has not been adjusted to the added parameter “Properties” which use is still unclear to me. Apart from that I have positive feedback regarding my tests with simple mediation and usage of the nhttp transports. I could not spot any problem so far. I also did a couple of small load tests against one small instance reaching about 2500 requests per second and letting it run on that level for a few hours. Regards, Eric ________________________________ From: Ruwan Linton [mailto:ruwan.lin...@gmail.com] Sent: Sunday, December 12, 2010 3:33 AM To: dev@synapse.apache.org Subject: Re: [VOTE] Release Synapse-2.0.0 (Take2) Hi Eric, On Sat, Dec 11, 2010 at 9:40 PM, Hubert, Eric <eric.hub...@foxmobile.com<mailto:eric.hub...@foxmobile.com>> wrote: I found another issue with the nhttp transports: I guess Synapse 2.0 release should not be shipped with http core / http core nio 4.1 alpha 1 dependencies, but the final release version 4.1. I also think the patch for httpcore-193 is no longer needed and the binary patch should not be in the patches directory. Cool, I guess a good catch, will fix it. Apart from that I finished the mediator migration and I’m now starting to test including custom mediators. Unfortunately I will have to continue tomorrow, as I have to take care of other things today. Sure no problem. Regards, Eric PS: Is there already an updated version of the migration tool to test? Unfortunately not yet Eric, I didn't have time to work on that, planning to work on resolving all the issue today starting from now on. :-) Will post the tool once there is an update. Thanks, Ruwan ________________________________ From: Ruwan Linton [mailto:ruwan.lin...@gmail.com<mailto:ruwan.lin...@gmail.com>] Sent: Thursday, December 09, 2010 11:08 AM To: dev@synapse.apache.org<mailto:dev@synapse.apache.org> Subject: Re: [VOTE] Release Synapse-2.0.0 (Take2) Hiranya, I've fixed this dependency issue, I expect you to do a build on the local machine and check this, will wait for your comments to the next RC :-) Thanks, Ruwan On Thu, Dec 9, 2010 at 12:44 AM, Hiranya Jayathilaka <hiranya...@gmail.com<mailto:hiranya...@gmail.com>> wrote: I hate to be a PITA but I see another issue with this. The FIX transport has been included in the latest binary. So that's good. But I can see that Quickfix/J has also crept into the distro (about 9MB). FIX transport also requires MINA and SLF4J which are not included in the binary. So IMO either we should include all the required dependencies or none of them. I think we should add an exclusion to Quickfix/J and keep it out of the binary. WDYT? Thanks, Hiranya On Wed, Dec 8, 2010 at 12:27 PM, Ruwan Linton <ruwan.lin...@gmail.com<mailto:ruwan.lin...@gmail.com>> wrote: > Hi Devs, > > This is take 2 call for votes to release Synapse-2.0.0. > > Please review the signed artifacts: > http://people.apache.org/~ruwan/synapse/2.0.0-RC2/artifacts/ > The m2 repository is available at: > http://people.apache.org/~ruwan/synapse/2.0.0-RC2/m2_repo/ > Site update for this release is available at: > http://people.apache.org/~ruwan/synapse/2.0.0-RC2/site/ > SVN Info: > revision is 1043322 on > https://svn.apache.org/repos/asf/synapse/branches/2.0 > Here's my +1 to declaring the above dist as Synapse-2.0.0. > > Thanks, > Ruwan > PS: The KEYS file for signing these > releases http://www.apache.org/dist/synapse/KEYS > -- > Ruwan Linton > Software Architect & Product Manager, WSO2 ESB; http://wso2.org/esb > WSO2 Inc.; http://wso2.org > > Lean . Enterprise . Middleware > > phone: +1 408 754 7388 ext 51789 > email: ru...@wso2.com<mailto:ru...@wso2.com>; cell: +94 77 341 3097 > blog: http://blog.ruwan.org > linkedin: http://www.linkedin.com/in/ruwanlinton > google: http://www.google.com/profiles/ruwan.linton > tweet: http://twitter.com/ruwanlinton > -- Hiranya Jayathilaka Senior Software Engineer; WSO2 Inc.; http://wso2.org E-mail: hira...@wso2.com<mailto:hira...@wso2.com>; Mobile: +94 77 633 3491 Blog: http://techfeast-hiranya.blogspot.com --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org<mailto:dev-unsubscr...@synapse.apache.org> For additional commands, e-mail: dev-h...@synapse.apache.org<mailto:dev-h...@synapse.apache.org> -- Ruwan Linton Software Architect & Product Manager, WSO2 ESB; http://wso2.org/esb WSO2 Inc.; http://wso2.org Lean . Enterprise . Middleware phone: +1 408 754 7388 ext 51789 email: ru...@wso2.com<mailto:ru...@wso2.com>; cell: +94 77 341 3097 blog: http://blog.ruwan.org linkedin: http://www.linkedin.com/in/ruwanlinton google: http://www.google.com/profiles/ruwan.linton tweet: http://twitter.com/ruwanlinton -- Ruwan Linton Software Architect & Product Manager, WSO2 ESB; http://wso2.org/esb WSO2 Inc.; http://wso2.org Lean . Enterprise . Middleware phone: +1 408 754 7388 ext 51789 email: ru...@wso2.com<mailto:ru...@wso2.com>; cell: +94 77 341 3097 blog: http://blog.ruwan.org linkedin: http://www.linkedin.com/in/ruwanlinton google: http://www.google.com/profiles/ruwan.linton tweet: http://twitter.com/ruwanlinton
