Sorry for the late reply. Here I'm attaching a diff.
Thanks, Supun.. On Fri, Dec 3, 2010 at 12:06 PM, Supun Kamburugamuva <[email protected]> wrote: > > > On Thu, Dec 2, 2010 at 12:16 AM, Hiranya Jayathilaka <[email protected]> > wrote: >> >> Hi Supun, >> >> On Wed, Dec 1, 2010 at 12:14 PM, Supun Kamburugamuva <[email protected]> >> wrote: >> > The way errors are handled in the SynapseCallbackReceiver is pretty >> > strange >> > to me. When an error happens at the transport sender this callback >> > receiver >> > is invoked. But when it is invoked, it uses the incoming message context >> > to >> > invoke the synapse configuration and send back the message. But there is >> > a >> > message context originated from the transport itself. Synapse callback >> > doesn't use this message context for invoking the language. >> >> Does the transport always have a response message context in case of a >> fault? What about in a situation like a connection failure? > > In all the failure cases including connection failures it creates a Fault > Message context. > > I'm working on a patch and once I'm done I'll submit it for review. > > Thanks, > Supun.. >> >> Thanks, >> Hiranya >> >> > This makes the life hard at the handling of faults in Synapse >> > configuration. >> > To send the fault back to the user, user has to do things like removing >> > the >> > To address and setting the RESPONSE to true. >> > I would like to re-factor this code to use the original message context >> > coming from the transport. WDYT? >> > Thanks, >> > Supun.. >> > >> > >> >> >> >> -- >> Hiranya Jayathilaka >> Senior Software Engineer; >> WSO2 Inc.; http://wso2.org >> E-mail: [email protected]; Mobile: +94 77 633 3491 >> Blog: http://techfeast-hiranya.blogspot.com >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > > > -- > Technical Lead, WSO2 Inc > http://wso2.org > supunk.blogspot.com > > > -- Technical Lead, WSO2 Inc http://wso2.org supunk.blogspot.com
callback_receiver.patch
Description: Binary data
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
