[GitHub] [synapse] n-jay commented on a diff in pull request #55: Add environment variable injection for SOAP and WSDL endpoints

[GitBox]

n-jay commented on code in PR #55:
URL: https://github.com/apache/synapse/pull/55#discussion_r979421396


##########
modules/core/src/main/java/org/apache/synapse/endpoints/WSDLEndpoint.java:
##########
@@ -93,15 +105,27 @@ public String getServiceName() {
         return serviceName;
     }
 
+    public String getGetOriginalWsdlServiceName() {
+        return this.getOriginalWsdlServiceName;
+    }
+
     public void setServiceName(String serviceName) {
-        this.serviceName = serviceName;
+        this.getOriginalWsdlServiceName = serviceName;
+        String fetchedServiceName = 
ConfigUtils.fetchEnvironmentVariables(serviceName);

Review Comment:
   Resolved 
https://github.com/apache/synapse/pull/55/commits/61fb9e4da909b00d6da8dfe9fb57a3c0a5892793



##########
modules/core/src/main/java/org/apache/synapse/endpoints/WSDLEndpoint.java:
##########
@@ -93,15 +105,27 @@ public String getServiceName() {
         return serviceName;
     }
 
+    public String getGetOriginalWsdlServiceName() {
+        return this.getOriginalWsdlServiceName;
+    }
+
     public void setServiceName(String serviceName) {
-        this.serviceName = serviceName;
+        this.getOriginalWsdlServiceName = serviceName;
+        String fetchedServiceName = 
ConfigUtils.fetchEnvironmentVariables(serviceName);
+        this.serviceName = fetchedServiceName;
     }
 
     public String getPortName() {
         return portName;
     }
 
+    public String getOriginalWsdlPort() {
+        return this.originalWsdlPort;
+    }
+
     public void setPortName(String portName) {
-        this.portName = portName;
+        this.originalWsdlPort = portName;
+        String fetchedPortName = 
ConfigUtils.fetchEnvironmentVariables(portName);

Review Comment:
   Resolved 
https://github.com/apache/synapse/pull/55/commits/61fb9e4da909b00d6da8dfe9fb57a3c0a5892793



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org
For additional commands, e-mail: dev-h...@synapse.apache.org