[
https://issues.apache.org/jira/browse/SYNCOPE-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526524#comment-13526524
]
Francesco Chicchiriccò commented on SYNCOPE-245:
------------------------------------------------
The patch looks fine; could you please
1. rename attribute() to attributeTO() (since the other method is called
attributeMod())
2. move these two methods to org.apache.syncope.core.rest.AbstractTest
3. do the same nice cleaning work to RoleTestITCase
Could you also please generate your patch from source root instead of core?
Thanks!
> Improve UserTestITCase
> ----------------------
>
> Key: SYNCOPE-245
> URL: https://issues.apache.org/jira/browse/SYNCOPE-245
> Project: Syncope
> Issue Type: Improvement
> Affects Versions: 1.0.3-incubating, 1.1.0
> Reporter: Christian Schneider
> Assignee: Francesco Chicchiriccò
> Fix For: 1.1.0
>
> Attachments: syncope_usertest.patch
>
>
> The test org.apache.syncope.core.rest.UserTestITCase has some highly
> repetitive code where AttributeTOs and AttributeMods are created. I created
> two small helper methods and was able to make the test about 150 lines
> smaller.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
