Christian Schneider created SYNCOPE-250:
-------------------------------------------
Summary: Improve error handling in NotificationTest
Key: SYNCOPE-250
URL: https://issues.apache.org/jira/browse/SYNCOPE-250
Project: Syncope
Issue Type: Improvement
Affects Versions: 1.1.0
Reporter: Christian Schneider
Fix For: 1.1.0
Inside the NotificationTest there are several try catch blocks like below:
} catch (Exception e) {
LOG.error("Unexpected exception", e);
fail("Unexpected exception while setting SMTP host and port");
}
This makes the code harder to read and at least on the junit level it swallows
the exception details and stack trace.
I propose to remove these blocks and instead let each of these method just
throw Exception. junit will then report the exception nicely.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
