[
https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529803#comment-13529803
]
Christian Schneider commented on SYNCOPE-242:
---------------------------------------------
Forgot the explanations. As the patch changes a lot of files here is a short
overview of what I did:
Move some classes to beans as they are needed from persistence layer
org.apache.syncope.core.persistence.beans.NotFoundException
org.apache.syncope.core.persistence.beans.PropagationActions
org.apache.syncope.core.persistence.beans.SyncActions
org.apache.syncope.core.persistence.beans.SyncResult
Move passwordencoder near beans.user as it is needed in SyncopeUser
org.apache.syncope.core.security ->
org.apache.syncope.core.persistence.beans.user.PasswordEncoder
Move exception to dao as it belongs to the DAO interface
org.apache.syncope.core.persistence.dao.InvalidSearchConditionException
Check for Job instead of AbstractJob to avoid referecne to quartz package
org.apache.syncope.core.persistence.validation.entity.SchedTaskValidator
(change AbstractTaskJob to Job)
Move ConnObjectUtil to separate package as it is needed outside of persistence
org.apache.syncope.core.conutil.ConnObjectUtil
org.apache.syncope.core.conutil.PasswordGenerator
Extract ConnectorRegistry, ConnectorFactory interface from ConnInstanceLoader
to avoid referencing ConnInstanceLoader from persistence
> Resolve dependency cycles between persistence and the rest of syncope core
> --------------------------------------------------------------------------
>
> Key: SYNCOPE-242
> URL: https://issues.apache.org/jira/browse/SYNCOPE-242
> Project: Syncope
> Issue Type: Improvement
> Affects Versions: 1.0.3-incubating
> Reporter: Christian Schneider
> Fix For: 1.1.0
>
> Attachments: SYNCOPE-242-1.patch, syncope_core_after.png,
> syncope_core_before.png
>
>
> When analysing if we could move the persistence and persistence impl into
> separate modules I found that there are a lot of dependency cycles in the
> syncope core module. I have added a structure 101 diagram of the cycles to
> the issue so you can take a look.
> Especially the cycles between persistence and the rest of core are important
> as they prevent us from moving these packages out of core.
> I have already done some experimentations how to solve the cycles and am
> pretty sure I can fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
