[
https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529954#comment-13529954
]
Christian Schneider commented on SYNCOPE-242:
---------------------------------------------
I tried to apply my patch to a clean trunk with the command above. I also had
to skip the moved files. In the end it reported 1 hunk.
Then when I compiled I got a lot of errors (see below).
So I assume the way I created or applied the patch is somehow wrong. For
creating the patch I used Team -> Create Patch in eclipse. What is the
recommended way to create a patch on the command line?
I also tried with svn diff > SYNCOPE-242-2.patch but had the same issues.
Any idea what I am doing wrong?
Christian
-----
[INFO] Compiling 289 source files to
/home/cschneider/checkout/syncope2/core/target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/persistence/beans/user/SyncopeUser.java:[65,36]
cannot find symbol
symbol : class PasswordEncoder
location: package org.apache.syncope.core.util
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/persistence/validation/entity/SyncopeUserCheck.java:[29,47]
package org.apache.syncope.core.validation.user does not exist
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/workflow/WorkflowAdapter.java:[36,21]
cannot find symbol
symbol : class WorkflowLoader
location: interface org.apache.syncope.core.workflow.WorkflowAdapter
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/persistence/dao/RoleDAO.java:[48,82]
cannot find symbol
symbol : class InvalidSearchConditionException
location: interface org.apache.syncope.core.persistence.dao.RoleDAO
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/persistence/dao/AttributableDAO.java:[36,47]
cannot find symbol
symbol : class InvalidSearchConditionException
location: interface org.apache.syncope.core.persistence.dao.AttributableDAO
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/persistence/dao/UserDAO.java:[36,82]
cannot find symbol
symbol : class InvalidSearchConditionException
location: interface org.apache.syncope.core.persistence.dao.UserDAO
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/rest/controller/RoleController.java:[31,38]
cannot find symbol
symbol : class ConnObjectUtil
location: package org.apache.syncope.core.connid
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/rest/controller/RoleController.java:[36,47]
cannot find symbol
symbol : class InvalidSearchConditionException
location: package org.apache.syncope.core.persistence.dao
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/rest/data/RoleDataBinder.java:[27,38]
cannot find symbol
symbol : class ConnObjectUtil
location: package org.apache.syncope.core.connid
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/propagation/PropagationManager.java:[34,38]
cannot find symbol
symbol : class ConnObjectUtil
location: package org.apache.syncope.core.connid
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/rest/controller/RoleController.java:[98,13]
cannot find symbol
symbol : class ConnObjectUtil
location: class org.apache.syncope.core.rest.controller.RoleController
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/rest/controller/RoleController.java:[204,20]
cannot access
org.apache.syncope.core.rest.controller.InvalidSearchConditionException
bad class file:
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/rest/controller/InvalidSearchConditionException.java
file does not contain class
org.apache.syncope.core.rest.controller.InvalidSearchConditionException
Please remove or make sure it appears in the correct subdirectory of the
classpath.
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/rest/data/RoleDataBinder.java:[55,13]
cannot find symbol
symbol : class ConnObjectUtil
location: class org.apache.syncope.core.rest.data.RoleDataBinder
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/rest/data/UserDataBinder.java:[31,38]
cannot find symbol
symbol : class ConnObjectUtil
location: package org.apache.syncope.core.connid
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/rest/data/UserDataBinder.java:[49,36]
cannot find symbol
symbol : class PasswordEncoder
location: package org.apache.syncope.core.util
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/propagation/PropagationManager.java:[107,13]
cannot find symbol
symbol : class ConnObjectUtil
location: class org.apache.syncope.core.propagation.PropagationManager
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/rest/data/UserDataBinder.java:[71,13]
cannot find symbol
symbol : class ConnObjectUtil
location: class org.apache.syncope.core.rest.data.UserDataBinder
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/persistence/validation/entity/ExternalResourceValidator.java:[27,49]
cannot find symbol
symbol : class PropagationActions
location: package org.apache.syncope.core.persistence.beans
[ERROR]
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/persistence/validation/entity/SyncopeUserCheck.java:[33,27]
cannot access
org.apache.syncope.core.persistence.validation.entity.SyncopeUserValidator
bad class file:
/home/cschneider/checkout/syncope2/core/src/main/java/org/apache/syncope/core/persistence/validation/entity/SyncopeUserValidator.java
file does not contain class
org.apache.syncope.core.persistence.validation.entity.SyncopeUserValidator
Please remove or make sure it appears in the correct subdirectory of the
classpath.
[INFO] 19 errors
> Resolve dependency cycles between persistence and the rest of syncope core
> --------------------------------------------------------------------------
>
> Key: SYNCOPE-242
> URL: https://issues.apache.org/jira/browse/SYNCOPE-242
> Project: Syncope
> Issue Type: Improvement
> Affects Versions: 1.0.3-incubating
> Reporter: Christian Schneider
> Fix For: 1.1.0
>
> Attachments: SYNCOPE-242-1.patch, SYNCOPE-242-2.patch,
> syncope_core_after.png, syncope_core_before.png
>
>
> When analysing if we could move the persistence and persistence impl into
> separate modules I found that there are a lot of dependency cycles in the
> syncope core module. I have added a structure 101 diagram of the cycles to
> the issue so you can take a look.
> Especially the cycles between persistence and the rest of core are important
> as they prevent us from moving these packages out of core.
> I have already done some experimentations how to solve the cycles and am
> pretty sure I can fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
