[
https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534056#comment-13534056
]
Christian Schneider commented on SYNCOPE-242:
---------------------------------------------
Thanks for applying the patch. When trying to move the peristence api into a
separate module I found that we can not leave the SyncopeUserValidator out of
the peristence API. It is used in the constraint @Constraint(validatedBy =
SyncopeUserValidator.class) of the @SyncopeUserCheck annotation.
As the SyncopeUserValidator needs the Account- and PasswordPolicyEnforcers we
have to find a way to make these also (at least partly move to the api. I found
a way to make this work by spearating the interface of the Enforcers from the
impls. So the SyncopeUserValidator only needs to reference the interfaces which
can then move to the api.
Should I open a new issue for this or should I just add a patch for it?
> Resolve dependency cycles between persistence and the rest of syncope core
> --------------------------------------------------------------------------
>
> Key: SYNCOPE-242
> URL: https://issues.apache.org/jira/browse/SYNCOPE-242
> Project: Syncope
> Issue Type: Improvement
> Affects Versions: 1.0.3-incubating
> Reporter: Christian Schneider
> Assignee: Jean-Baptiste Onofré
> Fix For: 1.1.0
>
> Attachments: SYNCOPE-242-1.patch, SYNCOPE-242-2.patch,
> SYNCOPE-242-fromtgz.patch, syncope_core_after.png, syncope_core_before.png,
> syncope.tgz
>
>
> When analysing if we could move the persistence and persistence impl into
> separate modules I found that there are a lot of dependency cycles in the
> syncope core module. I have added a structure 101 diagram of the cycles to
> the issue so you can take a look.
> Especially the cycles between persistence and the rest of core are important
> as they prevent us from moving these packages out of core.
> I have already done some experimentations how to solve the cycles and am
> pretty sure I can fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira