On 25/01/2013 17:13, Christian Schneider wrote:
On 25.01.2013 17:07, Francesco Chicchiriccò wrote:
On 25/01/2013 16:56, Christian Schneider wrote:
When doing the CXF version of the UserRequestService I found that our
current UserRequestController does not really follow the rest ideas.
The problem is that it does follow the idea of doing CRUD operations on
resources. Some methods work with userId others with requestId. So for
example the are create, update and delete operations but they
do not mean the UserRequest but the underlying user.
So I worked out a new interface that purely works on UserRequest and
only supports POST, READ and DELETE. So basically if you want to create
or delete or update a user you will POST a UserRequestTO in all cases.
Problem: you've already made all these changes *without* discussing
this before, once again not taking into any account the domain
requirements nor the compatibility with existing components, but only
the technology aspects.
We must fix this ASAP.
I also thought about this and if I should rather wait. My change only
affects the new interface. So the old controller stays the same and
stays active. The change should not affect anyone who uses the current
spring based rest interface.
As we already use the new interface in the console and the tests these
are of course affected but this should be only internal.
If you prefer I can roll back and wait for the result of the discussion.
For the moment it would be enough for me to have again a working admin
console, as it used to be before of this commit.
Regards.
--
Francesco Chicchiriccò
ASF Member, Apache Syncope PMC chair, Apache Cocoon PMC Member
http://people.apache.org/~ilgrosso/
