[
https://issues.apache.org/jira/browse/SYNCOPE-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837437#comment-13837437
]
Francesco Chicchiriccò commented on SYNCOPE-457:
------------------------------------------------
IMO, according to Syncope configuration style, I'd move {{smtp.host}} and
{{smtp.port}} out of {{SyncopeConf}} and define a {{JavaMailSenderImpl}} Spring
bean in {{core/src/main/resources/syncopeContext.xml}}, with parameters from an
external {{core/src/main/resources/mail.properties}}.
Finally, {{JavaMailSenderImpl}} will be {{@Autowired}} in {{NotificationJob}}.
WDYT?
> Must be able to configure JavaMailSender used by NotificationJob
> ----------------------------------------------------------------
>
> Key: SYNCOPE-457
> URL: https://issues.apache.org/jira/browse/SYNCOPE-457
> Project: Syncope
> Issue Type: Bug
> Components: core
> Affects Versions: 1.1.5, 1.2.0
> Reporter: Hadrian Zbarcea
> Assignee: Hadrian Zbarcea
> Fix For: 1.2.0
>
>
> In NotificationJob.executeSingle we instantiate a new JavaMailSenderImpl()
> which we then populate with some values. There are however other properties
> [1] that can be set on the Session. Some of them are very useful, especially
> in production environments.
> In particular, the 'mail.smtp.connectiontimeout' should be set to a different
> value than the default 'infinite' which would cause the thread to hang,
> waiting for a unresponsive SMTP server (either misconfiguration of server
> down).
> I will try to come up with a patch towards the end of the week if nobody
> beats me to it.
> [1] https://javamail.java.net/nonav/docs/api/
--
This message was sent by Atlassian JIRA
(v6.1#6144)
