[ 
https://issues.apache.org/jira/browse/SYNCOPE-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francesco Chicchiriccò resolved SYNCOPE-457.
--------------------------------------------

    Resolution: Fixed

Thanks for the patch: I have applied almost literally.
The only thing I have changed is the stuff for NotificationTest: I've preferred 
not introducing additional *.properties that, as lately happened with 
SYNCOPE-452, might cause some weird behavior. Now the test settings are applied 
at test's {{@Before}}, directly on the singleton Spring bean: this is not going 
anyway to cause any trouble to integration tests.

About migration guide: we are not preparing it yet since the release date does 
not seem too much close; anyway, I have just created an [empty migration 
page|https://cwiki.apache.org/confluence/display/SYNCOPE/Upgrade+from+1.1.X+to+1.2.X]
 that should eventually look close to [this 
one|https://cwiki.apache.org/confluence/display/SYNCOPE/Upgrade+from+1.0.X+to+1.1.X].
Please send me your Confluence username if you want to contribute also there.

> Must be able to configure JavaMailSender used by NotificationJob
> ----------------------------------------------------------------
>
>                 Key: SYNCOPE-457
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-457
>             Project: Syncope
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.1.5, 1.2.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>             Fix For: 1.2.0
>
>         Attachments: syncope-457.patch
>
>
> In NotificationJob.executeSingle we instantiate a new JavaMailSenderImpl() 
> which we then populate with some values. There are however other properties 
> [1] that can be set on the Session. Some of them are very useful, especially 
> in production environments.
> In particular, the 'mail.smtp.connectiontimeout' should be set to a different 
> value than the default 'infinite' which would cause the thread to hang, 
> waiting for a unresponsive SMTP server (either misconfiguration of server 
> down).
> I will try to come up with a patch towards the end of the week if nobody 
> beats me to it.
> [1] https://javamail.java.net/nonav/docs/api/



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to