[
https://issues.apache.org/jira/browse/SYNCOPE-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052946#comment-14052946
]
Guido Wimmel commented on SYNCOPE-531:
--------------------------------------
Just checked in a fix into 1_1_X. Verified that
AuthenticationTestITCase.checkFailedLogins() now runs successfully if
log.lastlogindate==false. I did a bit of refactoring, which changes the order
of calls on successful authentication (before, the modified user was saved
after calling auditManager - now the modified user is saved before calling
auditManager; on failed authentication the order did not change). If the
different order was intentional, I can change this.
@Francesco - could you take a look before I merge into trunk?
> Failed login counter not reset if log.lastlogindate==false
> ----------------------------------------------------------
>
> Key: SYNCOPE-531
> URL: https://issues.apache.org/jira/browse/SYNCOPE-531
> Project: Syncope
> Issue Type: Bug
> Components: core
> Affects Versions: 1.1.8, 1.2.0
> Reporter: Guido Wimmel
> Assignee: Guido Wimmel
> Priority: Minor
>
> The failed login counter SyncopeUser.getFailedLogins() is not set to zero on
> successful login if log.lastlogindate==false is set in the configuration. In
> particular, AuthenticationTestITCase.checkFailedLogins() fails if content.xml
> is modified such that log.lastlogindate==false.
> See also the discussion in SYNCOPE-507.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
