Hi,

we observed that when UserController.resolveReferences() is called before the 
creation of a User via UserController.create(),
Syncope tries to read the user with id==0 (via binder.getUserTO()). This always 
fails (which is ignored), but may cause an unnecessary query to the database 
and the creation of a transaction that must be rolled back because of a 
NotFoundException thrown by UserDataBinder.

This also would make it difficult to make functionality in UserController which 
creates users transactional.

Would it be a useful optimization to check for id!=0 in 
UserController.resolveReferences()? (and similar in other controllers?)

Is there a specific reason why create() is not marked transactional currently, 
but some other methods in UserController are?

Cheers,
  Guido



Reply via email to