Hi,
with your original patch, when added to Syncope sources (not to your
project sources), I got the following failures during integration tests
execution:
updateAsRoleOwner(org.apache.syncope.core.rest.RoleTestITCase) Time
elapsed: 0.148 sec <<< ERROR!
org.apache.syncope.common.SyncopeClientException: NotFound [AccountId
mapping for ROLE 7 on resource 'ws-target-resource-nopropagation']
at
org.apache.syncope.common.SyncopeClientException.build(SyncopeClientException.java:37)
at
org.apache.syncope.client.rest.RestClientExceptionMapper.checkSyncopeClientCompositeException(RestClientExceptionMapper.java:99)
at
org.apache.syncope.client.rest.RestClientExceptionMapper.fromResponse(RestClientExceptionMapper.java:56)
at
org.apache.syncope.client.rest.RestClientExceptionMapper.fromResponse(RestClientExceptionMapper.java:39)
at
org.apache.cxf.jaxrs.client.ClientProxyImpl.checkResponse(ClientProxyImpl.java:302)
at
org.apache.cxf.jaxrs.client.ClientProxyImpl.handleResponse(ClientProxyImpl.java:725)
at
org.apache.cxf.jaxrs.client.ClientProxyImpl.doChainedInvocation(ClientProxyImpl.java:683)
at
org.apache.cxf.jaxrs.client.ClientProxyImpl.invoke(ClientProxyImpl.java:224)
at com.sun.proxy.$Proxy42.update(Unknown Source)
at
org.apache.syncope.core.rest.RoleTestITCase.updateAsRoleOwner(RoleTestITCase.java:341)
updateWitApproval(org.apache.syncope.core.rest.UserSelfTestITCase) Time
elapsed: 0.173 sec <<< ERROR!
org.apache.syncope.common.SyncopeClientException: Workflow [Error while
evaluating expression: #{update.execute(execution.processInstanceId)}]
at
org.apache.syncope.common.SyncopeClientException.build(SyncopeClientException.java:37)
at
org.apache.syncope.client.rest.RestClientExceptionMapper.checkSyncopeClientCompositeException(RestClientExceptionMapper.java:99)
at
org.apache.syncope.client.rest.RestClientExceptionMapper.fromResponse(RestClientExceptionMapper.java:56)
at
org.apache.syncope.client.rest.RestClientExceptionMapper.fromResponse(RestClientExceptionMapper.java:39)
at
org.apache.cxf.jaxrs.client.ClientProxyImpl.checkResponse(ClientProxyImpl.java:302)
at
org.apache.cxf.jaxrs.client.ClientProxyImpl.handleResponse(ClientProxyImpl.java:725)
at
org.apache.cxf.jaxrs.client.ClientProxyImpl.doChainedInvocation(ClientProxyImpl.java:683)
at
org.apache.cxf.jaxrs.client.ClientProxyImpl.invoke(ClientProxyImpl.java:224)
at com.sun.proxy.$Proxy41.submitForm(Unknown Source)
at
org.apache.syncope.core.rest.UserSelfTestITCase.updateWitApproval(UserSelfTestITCase.java:210)
I have reworked your patch at https://paste.apache.org/2zJK and failures
are gone: can you try my patch and let me know if it still solves your
problem?
If so, can you please open an issue on JIRA with description of your
problem? Thanks.
Regards.
On 27/01/2015 14:24, Nicola Baiocco wrote:
We currently use this patch in our core overlay.
we've left line 106 commented because we don't understand its meaning of this
one, this type of operation should be performed after this routine (as happens
for role process) otherwise will lost the old values.
All the other comments are our missing, sorry.
Hope this will clarify a little bit.
-----Messaggio originale-----
Da: Francesco Chicchiriccò [mailto:[email protected]]
Inviato: martedì 27 gennaio 2015 14:11
A:[email protected]
Oggetto: Re: User and Role Data binder problem
On 27/01/2015 14:07, Nicola Baiocco wrote:
Here, our solution patch:
http://apaste.info/Fqa
Thanks: have you tried to apply such patch to Syncope sources and to check that
the build runs successfully?
Minor note: I see comments in the patch, you should remove them.
Regards.
-----Messaggio originale-----
Da: Francesco Chicchiriccò [mailto:[email protected]]
Inviato: martedì 27 gennaio 2015 13:31
A:[email protected]
Oggetto: Re: User and Role Data binder problem
On 27/01/2015 13:29, Francesco Chicchiriccò wrote:
On 26/01/2015 16:25, Nicola Baiocco wrote:
Hi,
we have some problem during update propagations to external resource
of users and roles in Syncope 1.2.1.
In our case, the external resource has a derived attribute
configured as account id.
During the propagation task it seems that syncope performs a
getRemoteObject operation (in AbstractPropagationTaskExecutor)
passing username/rolename attribute instead of the designed account
id attribute (internal attribute specified in user/role mapping
configuration).
This behavior it seems an issue and we have resolved with attached
patch.
Could you confirm that?
Otherwise if we have a misunderstanding could you explain what is
the business logic behind this routine (UserDataBinder update and
RoleDataBinder update).
Hi Nicola,
sorry I cannot see your patch - probably it's safer to paste it to
https://paste.apache.org/
Sorry,http://apaste.info/ should work (the one above is for ASF committers).
You should also provide some more information about your resource
mapping.
--
Francesco Chicchiriccò
Tirasa - Open Source Excellence
http://www.tirasa.net/
Involved at The Apache Software Foundation:
member, Syncope PMC chair, Cocoon PMC, Olingo PMC
http://people.apache.org/~ilgrosso/
