Il 24/03/2015 14:31, Francesco Chicchiriccò ha scritto:
On 24/03/2015 14:14, Francesco Chicchiriccò wrote:
On 24/03/2015 14:10, Fabio Martelli wrote:
Il 24/03/2015 13:16, Francesco Chicchiriccò ha scritto:
On 24/03/2015 12:28, Fabio Martelli wrote:
Il 23/03/2015 14:26, Francesco Chicchiriccò ha scritto:
Hi all,
I've summarized at [1] the feature and changes that I intend to implement about security realms.

Please take a look and let me know your thoughts: my idea is to start working on this topic in more or less one month, so we have plenty of time to discuss.

Regards.

[1] https://cwiki.apache.org/confluence/display/SYNCOPE/%5BDISCUSS%5D+Realms

Francesco, as you already know, you have my sponsorship for this new feature. Thank you for the wiki page.
Just a comment: I'm not sure about the suggested REST API change.

For example, to get users under a certain path you are proposing to have a request like as

GET /users/a/b

Why not the following?

GET /a/b/users

Personally, I'd prefer to have the path before in every request; something like as below.

Why? Because otherwise we would need to implement custom routing of each and every single REST call :-)

Hi Francesco, thanks for your prompt reply.
I was suggesting something like as below.

  @Path("/{path:.*}/users)
  public Response get(@PathParam("path") final String path) {
    ......
  }

Am I missing something?

Currently "users" is bound to the whole UserService class (and similar for other 10+ services): are you suggesting we need to completely review / rewrite our REST API level?

Alternatively, why not moving the realm from path to request parameter, e.g. from

GET /users/a/b

to

GET /users?realm=/a/b

WDYT?

Hey, it sounds with me.
Now I get your reasons and I do think that this is a good compromise.

+1

Best regards,
F.

--
Fabio Martelli

Tirasa - Open Source Excellence
http://www.tirasa.net/

Apache Syncope PMC
http://people.apache.org/~fmartelli/

Reply via email to