Re: Adding russian language to UI

Wed, 13 Apr 2016 23:47:41 -0700 

Hi Dmitriy,
so it seems you made it, huge congrats!

I have also updated the live demo at

http://syncope-vm.apache.org:9080/syncope-console/
Now we would highly appreciate if you keep staying around, since we will likely need to add further translations for the element currently missing in admin console (mainly policy and report management). 

Thanks again.
Regards.

On 12/04/2016 10:30, Francesco Chicchiriccò wrote:

On 12/04/2016 10:18, Dmitriy Berezkin wrote:

I already added missing translations, but didn't remove unused keys. I
believed that it is not an error if one property file have unused keys. But 
mvn have another opinion :)
So now I dont have translation for approvals and notifications yet, but I'm 
working on it.


Great!
Please consider that the console is still under development (some features are currently still missing, we're working on this), so I would suggest to complete what is currently available (approvals and notifications), merge the PR and then listen for more translation requests in the future, when the missing parts will be implemented. 


Here is my progress:
https://github.com/securny/syncope/tree/ru (This branch is 13 commits ahead 
of apache:master)
Looks good: please don't forget, when you will create the PR, to mention "SYNCOPE-828" and, possibly, to squeeze al of your commits into one (in order to maintain a cleaner history). Should this latter request be a problem, don't mind, we'll do it for you. 

Regards.


2016-04-12 11:07 GMT+03:00 Francesco Chicchiriccò <ilgro...@apache.org>:


On 12/04/2016 10:05, Dmitriy Berezkin wrote:


Thank you Fabio!
I removed old keys from *_ru.properties files and now dont have any
errors:


That's good; but consider that ow you are missing some Russian
translations...


2016-04-12 11:00 GMT+03:00 Fabio Martelli <fabio.marte...@gmail.com>:

Il 12/04/2016 09:47, Dmitriy Berezkin ha scritto:

So if I remove 'task.generic.list' from

'TopologyTogglePanel_ru.properties' it
will fix this 3 errors:

[ERROR]
src/main/resources/org/apache/syncope/client/console/topology/TopologyTogglePanel_it.properties:[0] 
(misc) Translation: Key 'task.generic.list' missing.
[ERROR]
src/main/resources/org/apache/syncope/client/console/topology/TopologyTogglePanel_pt_BR.properties:[0] 
(misc) Translation: Key 'task.generic.list' missing.
[ERROR]
src/main/resources/org/apache/syncope/client/console/topology/TopologyTogglePanel.properties:[0] 
(misc) Translation: Key 'task.generic.list' missing.

Right?

Hi Dmitriy, the problem occurs when a key is missing in one or more

files
/ conversely if it is present not in all the properties.
I mean, about the problem above, probably you specified task.generic.list 
in your Russian translation but you are missing it into the English,
Italian and Portuguese ones.
In this case, you have to remove the key from your new file.
Please, check your new properties files: they have to include all the key 
existing into the English translation; no one more no one less.

Kind regards,
F.
2016-04-12 10:42 GMT+03:00 Francesco Chicchiriccò <ilgro...@apache.org>: 
On 12/04/2016 09:31, Dmitriy Berezkin wrote:


I updated my fork and cant debug it because of errors:
In the commits you used to miss there have been several wicket message
keys that were removed or renamed - actually, some properties file were 
also added, removed or renamed.
In general, you should assume now that default (en), it and pt_BR are 
right and ru is wrong; so, for example,  if 'task.generic.list' is
missing
in the existing translations, you should take a look at
TopologyTogglePanel.properties, find the new name 'task.custom.list', 
and
update TopologyTogglePanel_ru.properties accordingly.
Not a fun task, I know, but it happens when you work with concurrent 
modifications...
Please see if you are able to fix all errors below and report here in 
case
of further troubles.

Thanks for your effort.
Regards.


[INFO] There are 24 errors reported by Checkstyle 6.11.2 with
/syncope/client/console/../../src/main/resources/org/apache/syncope/checkstyle.xml 
ruleset.
[ERROR]
src/main/resources/org/apache/syncope/client/console/topology/TopologyTogglePanel_it.properties:[0] 
(misc) Translation: Key 'task.generic.list' missing.
[ERROR]
src/main/resources/org/apache/syncope/client/console/topology/TopologyTogglePanel_pt_BR.properties:[0] 
(misc) Translation: Key 'task.generic.list' missing.
[ERROR]
src/main/resources/org/apache/syncope/client/console/topology/TopologyTogglePanel.properties:[0] 
(misc) Translation: Key 'task.generic.list' missing.
[ERROR]
target/classes/org/apache/syncope/client/console/panels/ResourceModal_it.properties:[0] 
(misc) Translation: Key 'actionsClasses' missing.
[ERROR]
target/classes/org/apache/syncope/client/console/panels/ResourceModal_it.properties:[0] 
(misc) Translation: Key 'listview.caption' missing.
[ERROR]
target/classes/org/apache/syncope/client/console/panels/ResourceModal.properties:[0] 
(misc) Translation: Key 'actionsClasses' missing.
[ERROR]
target/classes/org/apache/syncope/client/console/panels/ResourceModal.properties:[0] 
(misc) Translation: Key 'listview.caption' missing.
[ERROR]
target/classes/org/apache/syncope/client/console/panels/ResourceModal_pt_BR.properties:[0] 
(misc) Translation: Key 'actionsClasses' missing.
[ERROR]
target/classes/org/apache/syncope/client/console/panels/ResourceModal_pt_BR.properties:[0] 
(misc) Translation: Key 'listview.caption' missing.
[ERROR]
target/classes/org/apache/syncope/client/console/SyncopeConsoleApplication.properties:[0] 
(misc) Translation: Key 'todo' missing.
[ERROR]
target/classes/org/apache/syncope/client/console/SyncopeConsoleApplication_it.properties:[0] 
(misc) Translation: Key 'todo' missing.
[ERROR]
target/classes/org/apache/syncope/client/console/SyncopeConsoleApplication_pt_BR.properties:[0] 
(misc) Translation: Key 'todo' missing.
[ERROR]
src/main/resources/org/apache/syncope/client/console/SyncopeConsoleApplication.properties:[0] 
(misc) Translation: Key 'todo' missing.
[ERROR]
src/main/resources/org/apache/syncope/client/console/SyncopeConsoleApplication_it.properties:[0] 
(misc) Translation: Key 'todo' missing.
[ERROR]
src/main/resources/org/apache/syncope/client/console/SyncopeConsoleApplication_pt_BR.properties:[0] 
(misc) Translation: Key 'todo' missing.
[ERROR]
src/main/resources/org/apache/syncope/client/console/panels/ResourceModal_pt_BR.properties:[0] 
(misc) Translation: Key 'actionsClasses' missing.
[ERROR]
src/main/resources/org/apache/syncope/client/console/panels/ResourceModal_pt_BR.properties:[0] 
(misc) Translation: Key 'listview.caption' missing.
[ERROR]
src/main/resources/org/apache/syncope/client/console/panels/ResourceModal.properties:[0] 
(misc) Translation: Key 'actionsClasses' missing.
[ERROR]
src/main/resources/org/apache/syncope/client/console/panels/ResourceModal.properties:[0] 
(misc) Translation: Key 'listview.caption' missing.
[ERROR]
src/main/resources/org/apache/syncope/client/console/panels/ResourceModal_it.properties:[0] 
(misc) Translation: Key 'actionsClasses' missing.
[ERROR]
src/main/resources/org/apache/syncope/client/console/panels/ResourceModal_it.properties:[0] 
(misc) Translation: Key 'listview.caption' missing.
[ERROR]
target/classes/org/apache/syncope/client/console/topology/TopologyTogglePanel.properties:[0] 
(misc) Translation: Key 'task.generic.list' missing.
[ERROR]
target/classes/org/apache/syncope/client/console/topology/TopologyTogglePanel_pt_BR.properties:[0] 
(misc) Translation: Key 'task.generic.list' missing.
[ERROR]
target/classes/org/apache/syncope/client/console/topology/TopologyTogglePanel_it.properties:[0] 
(misc) Translation: Key 'task.generic.list' missing.

Do I need to run something?


2016-04-08 14:10 GMT+03:00 Dmitriy Berezkin <
berezkin.dmit...@gmail.com


:


1. berezkin

2. Ok

2016-04-08 14:03 GMT+03:00 Francesco Chicchiriccò <
ilgro...@apache.org


:


On 08/04/2016 12:58, Dmitriy Berezkin wrote:

Thank you, Francesco!

I'll check for update for my fork before sending PR!
I'm trying to act carefully to prevent possible damage of source 
files.

Attention to details is much appreciated ;-)

I have created

https://issues.apache.org/jira/browse/SYNCOPE-828

1. What is your JIRA username so that I can assign it to you?
2. Once done, please be sure to include the text "SYNCOPE-828" in 
your
PR
title


Regards.

2016-04-08 13:52 GMT+03:00 Francesco Chicchiriccò <
ilgro...@apache.org

:

On 08/04/2016 12:50, Dmitriy Berezkin wrote:

Hi Francesco!


I almost finished.


Now I have a fork with branch for RU locale:
https://github.com/securny/syncope/tree/ru
I left to finish just two files:ConnectorModal and ResourceModal. 
After
this I'll create pull-request.

Hey, nice work :-)

I see that your fork is 56 commits behind: please be sure to
align


to
Syncope before sending any PR.

Regards.


2016-04-08 13:43 GMT+03:00 Francesco Chicchiriccò <
ilgro...@apache.org

:


Hi Dmitriy,

I was wondering if you got any further progress.

Regards.


On 28/03/2016 08:35, Francesco Chicchiriccò wrote:

On 28/03/2016 08:21, Dmitriy Berezkin wrote:

Francesco, thank you for your patience!

I don really know why, but it began to work as expected!

Great, I've seen some screenshots from Twitter:

https://pbs.twimg.com/media/CenW6U0WsAA3Sr3.jpg:large

https://pbs.twimg.com/media/CenW6fUWQAA_5dA.jpg:large

Looks definitely good!
My guess is that the error you used to receive was related to 
some
missing translation.

At this time I'm working with local git repo. But I will
create a
fork
on

github to be able to show you my changes and submit pull
request.

Great, looking forward to that.


I also sent ICLA to apache secretary.
AFAICT the ICLA isn't processed yet, I'll tell you when we get 
notified
about that.
Regards, and keep up good work!

2016-03-26 21:44 GMT+03:00 Francesco Chicchiriccò <
ilgro...@apache.org

:

On 26/03/2016 19:26, Dmitriy Berezkin wrote:
You were absolutely right! I missed mvn clean and didnt see 

changes.

Now I
can see Russian in dropdown list but I'm getting error if I 


choose
it.
Here is the error:
HTTP Status 500 -

You need to take a look at files under
fit/console-reference/target/log/*.log for digging out the 
actual

cause.


As said below, I can take a closer look but you need to
publish
your
changes somewhere - assuming that you have forked

https://github.com/apache/syncope
could you please commit your modifications and tell me which 
fork
is
yours?

Regards.


2016-03-26 20:13 GMT+03:00 Francesco Chicchiriccò <
ilgro...@apache.org

:

Hi,
your images are not visible, but I've seen them on twitter I 
guess

;-)
After modifying SyncopeConsoleApplication.java (and adding 
the
properties
files), have you issued

mvn clean install

under client/console
*before* going into fit/console-reference and running mvn 
-Pdebug?
Anyway, are your changes published somewhere so I can take 
a
look?
GitHub
fork?

Regards.

On 26/03/2016 18:06, Dmitriy Berezkin wrote:
I'm trying to add russian locale to dropdown list at login 
page.

I added russian locale to line 73 to
SyncopeConsoleApplication.java

and

run mvn -Pdebug.
But I dont see any changes to language dropdown list at 
localhost:9080/syncope-console/
What should I check to fix it? Looks like I missed
something.

Here is source with locale:

​
And here is container running from mvn -Pdebug:


2016-03-24 11:44 GMT+03:00 Francesco Chicchiriccò <
ilgro...@apache.org
<mailto:ilgro...@apache.org>>:
On 24/03/2016 09:26, Dmitriy Berezkin wrote: 

                Hi!
                Thank you for worrying.
                I cloned git, found all language
*.properties
files
and
almost
                finished
                with
"SyncopeConsoleApplication_ru.properties".
I didn't configured yet my dev environment 
to
test
my
modifications, but
                building project with mvn works fine.
Great: looking forward to take a look at the 
results
:-)
In the meanwhile, could you please take a look 
at

http://syncope.apache.org/contributing.html
and send an ICLA (instructions there)? Thanks! 

            Regards.


                2016-03-24 11:01 GMT+03:00 Francesco
Chicchiriccò
<ilgro...@apache.org <mailto:
ilgro...@apache.org

:

Hi,
any progress so far? Have you attempted 
the
procedure
described at [1]?

                    Regards.

                    On 22/03/2016 10:44, Francesco
Chicchiriccò
wrote:
On 22-mar-16, at 10:32, Francesco 
Chicchiriccò
ilgro...@apache.org <mailto:
ilgro...@apache.org
ha
scritto:
On 22-mar-16, at 10:20, Dmitriy 
Berezkin
berezkin.dmit...@gmail.com
<mailto:berezkin.dmit...@gmail.com>

wrote:

Hi all!

I would like to translate
syncope
2.0.0
UI
to
russian language. I'm
looking
for preinstalled
environment
to
get
started
with syncope 2.0.0-M2.
It will be great if russian
language
support
for syncope UI will be OOTB
for 2.0.0 release.

Hi Dmitriy,
this sounds just great; right
now
I
am
updating
[1] which gives some
indications
and a draft procedure for
adding
new
translations
to the admin console.

Once done I'll update there,
stay
tuned.
The page [1] is now updated: please 
take
a
look
and
                        let us know.
Regards.

                        [1]
https://cwiki.apache.org/confluence/display/SYNCOPE/Adding+new+language+to+admin+console+UI 

--



--

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Involved at The Apache Software Foundation:
member, Syncope PMC chair, Cocoon PMC, Olingo PMC, CXF committer 
http://home.apache.org/~ilgrosso/



--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Involved at The Apache Software Foundation:
member, Syncope PMC chair, Cocoon PMC, Olingo PMC, CXF committer
http://home.apache.org/~ilgrosso/

Reply via email to