[ 
https://issues.apache.org/jira/browse/SYNCOPE-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333577#comment-15333577
 ] 

ASF GitHub Bot commented on SYNCOPE-721:
----------------------------------------

Github user ilgrosso commented on a diff in the pull request:

    https://github.com/apache/syncope/pull/22#discussion_r67326854
  
    --- Diff: pom.xml ---
    @@ -1177,6 +1180,16 @@ under the License.
           </dependency>
           <dependency>
             <groupId>org.webjars.bower</groupId>
    +        <artifactId>angular-translate</artifactId>
    +        <version>${angular-translate.version}</version>
    +      </dependency>
    +      <dependency>
    --- End diff --
    
    This dependency is also available as 
`org.webjars.bower:angular-translate-loader-partial`, with same version as 
`angular-translate`.
    
    I would replace
    
    ```
    <dependency>
           <groupId>org.webjars</groupId>
          <artifactId>angular-translate-loader-partial</artifactId>
           <version>${angular-translate-loader-partial.version}</version>
         </dependency>
    ```
    
    with
    
    ```
    <dependency>
        <groupId>org.webjars.bower</groupId>
        <artifactId>angular-translate-loader-partial</artifactId>
        <version>${angular-translate.version}</version>
    </dependency>
    ```
    
    and adjust the `index.html` above accordingly.


> Enduser i18n
> ------------
>
>                 Key: SYNCOPE-721
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-721
>             Project: Syncope
>          Issue Type: New Feature
>          Components: enduser
>            Reporter: Andrea Patricelli
>             Fix For: 2.0.0
>
>
> Add i18n to angular application. It may be useful to export and load once a 
> JSON file with translated labels and get translations from it at runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to