Github user ilgrosso commented on a diff in the pull request:

    https://github.com/apache/syncope/pull/36#discussion_r77491727
  
    --- Diff: 
core/logic/src/main/java/org/apache/syncope/core/logic/init/ClassPathScanImplementationLookup.java
 ---
    @@ -74,6 +75,8 @@
         private Map<Class<? extends AccountRuleConf>, Class<? extends 
AccountRule>> accountRuleClasses;
     
         private Map<Class<? extends PasswordRuleConf>, Class<? extends 
PasswordRule>> passwordRuleClasses;
    +    
    +    private List<String> basePackages = 
Arrays.asList("org.apache.syncope.fit.core", "org.apache.syncope.core");
    --- End diff --
    
    Prior to this change, one could create classes, in its own Maven-based 
Syncope project, under any package, now it is forced to do it under 
`org.apache.syncope.client.console` but we got more startup speed.
    I guess it is an acceptable trade-off.
    
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to