Hi,
As mentioned on IRC, I have a few questions about some issues raised by
FindBugs in the client module.
1) AjaxWizardMgtButtonBar +46...there is a call to
"wizard.getWizardModel().isCancelVisible();" which ignores the return
value. Not sure what the purpose of this line is?
2) ApprovalsWidget +72 - "if (!latestAlerts.equals(updatedApprovals)) {".
This equality check is faulty, as latestAlerts is of type "IModel<List<T>>"
whereas updatedApprovals is of type "List<WorkflowFormTO>". What should
this check be instead?
3) EntitlementSyncopeOperations +73 -
"role.getEntitlements().contains(entitlement);" ignores the return value.
I'm guessing this should be in an "if" statement?
Thanks,
Colm.
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
