Hi Misagh,
I've never heard about this plugin, but sounds good. I'm a fan of
self-contained solutions :)
So +1 for me.
Maybe is out of the scope of the plugin, but my only concern is about
the JDK on which maven relies (and Syncope needs to be built to have a
consistent artifact). Often the main build problems for users come from
"wrong" JDK versions used. Does this plugin also handles JDK versions in
a self-contained manner?
I'm referring for example to problems faced in this ML issue [1].
Best regards,
Andrea
[1]
https://lists.apache.org/thread.html/81777cfa04c8463ca6c3b8e344506982b29d923c8122b913c49273c6@%3Cuser.syncope.apache.org%3E
Il 25/09/19 10:05, Misagh Moayyed ha scritto:
Hello all,
I have proposed a pull request [1] to enable the maven wrapper plugin for
Syncope. This is a plugin that allows one to build and run Syncope from source
without having to install Maven locally. It's able to download and configure
the appropriate maven version automatically, and then proceeds as if it was
locally installed and available.
There are a number of advantages to using the wrapper:
- Contributors to Syncope do not have to have Maven downloaded/installed
locally, though nothing would prevent them from doing so.
- This should also prevent conflicts by allowing usage a specific install of
maven for Syncope, in case one might need different maven versions on their
system for different projects, etc.
- The wrapper makes sure the correct version of maven is downloaded and installed,
removing potential confusing around "If I do install maven locally, what version of
Maven do I need?"
- The maven version is controlled by the project for CI tests, and not by the
CI system itself, which is useful in case CI decides to change/update versions
or goes outdated for any reason.
- The maintenance and overhead of the change is very minimal where future
changes to the maven version are controlled with a simple properties file.
How do others feel about this change?
--Misagh
[1] https://github.com/apache/syncope/pull/122
--
Dott. Andrea Patricelli
Tel. +39 3204524292
Engineer @ Tirasa S.r.l.
Viale Vittoria Colonna 97 - 65127 Pescara
Tel +39 0859116307 / FAX +39 0859111173
http://www.tirasa.net
Apache Syncope PMC Member
