mat-ale commented on a change in pull request #178:
URL: https://github.com/apache/syncope/pull/178#discussion_r417332912
##########
File path:
wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java
##########
@@ -0,0 +1,25 @@
+/*
Review comment:
@mmoayyed What do you mean with "So perhaps we can just return `false`
here"?
According to your clarification I guess that one option could be to pull out
the `getSyncopeClient()` from the `try/catch` and make it throw the blocking
exception in order to block the execution.
But about the `SyncopeCoreNotReadyException`, do you guys want to keep it or
just throw a `RuntimeException` with `Syncope core is not yet ready to access
requests` as message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
