ilgrosso commented on a change in pull request #241:
URL: https://github.com/apache/syncope/pull/241#discussion_r566138845
##########
File path:
client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/DomainWizardBuilder.java
##########
@@ -103,7 +103,7 @@ public Storage(final Domain domain) {
add(new AjaxTextFieldPanel(
"jdbcURL",
"jdbcURL",
- new PropertyModel<>(domain, "jdbcURL")).setRequired(true));
+ new PropertyModel<>(domain,
"jdbcURL")).setRequired(true).addRequiredLabel());
Review comment:
for all occurrences of course
##########
File path:
client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/DomainWizardBuilder.java
##########
@@ -103,7 +103,7 @@ public Storage(final Domain domain) {
add(new AjaxTextFieldPanel(
"jdbcURL",
"jdbcURL",
- new PropertyModel<>(domain, "jdbcURL")).setRequired(true));
+ new PropertyModel<>(domain,
"jdbcURL")).setRequired(true).addRequiredLabel());
Review comment:
```.setRequired(true).addRequiredLabel()``` should be replaced by
```.addRequiredLabel()``` as the latter's implementation contains the former
call
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
