ilgrosso commented on a change in pull request #251: URL: https://github.com/apache/syncope/pull/251#discussion_r603231512
########## File path: core/am/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/wa/ImpersonationServiceImpl.java ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.syncope.core.rest.cxf.service.wa; + +import org.apache.syncope.common.lib.wa.ImpersonationAccount; +import org.apache.syncope.common.rest.api.RESTHeaders; +import org.apache.syncope.common.rest.api.service.wa.ImpersonationService; +import org.apache.syncope.core.logic.wa.ImpersonationLogic; +import org.apache.syncope.core.rest.cxf.service.AbstractServiceImpl; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.stereotype.Service; + +import javax.ws.rs.core.Response; + +import java.net.URI; +import java.util.List; + +@Service +public class ImpersonationServiceImpl extends AbstractServiceImpl implements ImpersonationService { + + @Autowired + private ImpersonationLogic logic; + + @Override + public List<ImpersonationAccount> findByOwner(final String owner) { + return logic.findByOwner(owner); + } + + @Override + public Response find(final String owner, + final String id, + final String application) { + return logic.find(owner, id, application) Review comment: this kind of security checks should be delegated to the logic layer, by Spring Security annotations if possible, otherwise by raising the appropriate client exception ########## File path: core/am/logic/src/main/java/org/apache/syncope/core/logic/wa/ImpersonationLogic.java ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.syncope.core.logic.wa; + +import org.apache.syncope.common.lib.types.AMEntitlement; +import org.apache.syncope.common.lib.types.IdRepoEntitlement; +import org.apache.syncope.common.lib.wa.ImpersonationAccount; +import org.apache.syncope.core.logic.AbstractAuthProfileLogic; +import org.apache.syncope.core.persistence.api.entity.EntityFactory; +import org.apache.syncope.core.persistence.api.entity.auth.AuthProfile; +import org.apache.syncope.core.spring.security.SecureRandomUtils; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.security.access.prepost.PreAuthorize; +import org.springframework.stereotype.Component; + +import java.util.ArrayList; +import java.util.List; + +@Component +public class ImpersonationLogic extends AbstractAuthProfileLogic { + + @Autowired + private EntityFactory entityFactory; + + @PreAuthorize("hasRole('" + AMEntitlement.IMPERSONATION_READ_ACCOUNT + "')" + + "or hasRole('" + IdRepoEntitlement.ANONYMOUS + "')") + public List<ImpersonationAccount> findByOwner(final String owner) { + return authProfileDAO.findByOwner(owner).map(AuthProfile::getImpersonationAccounts).orElse(List.of()); + } + + @PreAuthorize("hasRole('" + AMEntitlement.IMPERSONATION_READ_ACCOUNT + "')" + + "or hasRole('" + IdRepoEntitlement.ANONYMOUS + "')") + public Boolean find(final String owner, + final String id, + final String application) { Review comment: CodeQL reports that `application` is unused here. ########## File path: core/am/logic/src/main/java/org/apache/syncope/core/logic/wa/ImpersonationLogic.java ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.syncope.core.logic.wa; + +import org.apache.syncope.common.lib.types.AMEntitlement; +import org.apache.syncope.common.lib.types.IdRepoEntitlement; +import org.apache.syncope.common.lib.wa.ImpersonationAccount; +import org.apache.syncope.core.logic.AbstractAuthProfileLogic; +import org.apache.syncope.core.persistence.api.entity.EntityFactory; +import org.apache.syncope.core.persistence.api.entity.auth.AuthProfile; +import org.apache.syncope.core.spring.security.SecureRandomUtils; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.security.access.prepost.PreAuthorize; +import org.springframework.stereotype.Component; + +import java.util.ArrayList; +import java.util.List; + +@Component +public class ImpersonationLogic extends AbstractAuthProfileLogic { + + @Autowired + private EntityFactory entityFactory; + + @PreAuthorize("hasRole('" + AMEntitlement.IMPERSONATION_READ_ACCOUNT + "')" + + "or hasRole('" + IdRepoEntitlement.ANONYMOUS + "')") + public List<ImpersonationAccount> findByOwner(final String owner) { + return authProfileDAO.findByOwner(owner).map(AuthProfile::getImpersonationAccounts).orElse(List.of()); + } + + @PreAuthorize("hasRole('" + AMEntitlement.IMPERSONATION_READ_ACCOUNT + "')" + + "or hasRole('" + IdRepoEntitlement.ANONYMOUS + "')") + public Boolean find(final String owner, + final String id, + final String application) { + return authProfileDAO.findByOwner(owner) + .map(profile -> profile.getImpersonationAccounts() + .stream() + .anyMatch(acct -> acct.getId().equalsIgnoreCase(id))) + .stream().findFirst().orElse(Boolean.FALSE); + } + + @PreAuthorize("hasRole('" + AMEntitlement.IMPERSONATION_CREATE_ACCOUNT + "')" + + "or hasRole('" + IdRepoEntitlement.ANONYMOUS + "')") + public String create(final ImpersonationAccount account) { + if (account.getKey() == null) { + account.setKey(SecureRandomUtils.generateRandomUUID().toString()); Review comment: This is not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
