ilgrosso commented on a change in pull request #273:
URL: https://github.com/apache/syncope/pull/273#discussion_r650693344
##########
File path:
core/am/logic/src/main/java/org/apache/syncope/core/logic/wa/GoogleMfaAuthAccountLogic.java
##########
@@ -57,6 +58,26 @@ public void deleteFor(final String owner) {
});
}
+ @PreAuthorize("hasRole('" + IdRepoEntitlement.ANONYMOUS + "')")
+ public void deleteFor(final long id) {
Review comment:
Please rename this method as `delete()`
##########
File path: pom.xml
##########
@@ -2045,40 +2005,6 @@ under the License.
<enabled>true</enabled>
</releases>
</repository>
-
- <!-- Disable some Spring repositories pulled in by dependencies - see
Review comment:
Why removing disabled Spring repositories here?
##########
File path: pom.xml
##########
@@ -2045,40 +2005,6 @@ under the License.
<enabled>true</enabled>
</releases>
</repository>
-
- <!-- Disable some Spring repositories pulled in by dependencies - see
Review comment:
Isn't the information provided in the given link still valid?
##########
File path: pom.xml
##########
@@ -2045,40 +2005,6 @@ under the License.
<enabled>true</enabled>
</releases>
</repository>
-
- <!-- Disable some Spring repositories pulled in by dependencies - see
Review comment:
Isn't the information provided in the [given
link](https://spring.io/blog/2020/10/29/notice-of-permissions-changes-to-repo-spring-io-fall-and-winter-2020)
still valid?
There are dependencies that have such repos defined hence Syncope builds
will report permission errors; we added such definitions to stop pulling from
such repos.
##########
File path: pom.xml
##########
@@ -2045,40 +2005,6 @@ under the License.
<enabled>true</enabled>
</releases>
</repository>
-
- <!-- Disable some Spring repositories pulled in by dependencies - see
Review comment:
There are dependencies that have such repos defined hence Syncope builds
will report permission errors; we added such definitions to stop pulling from
such repos.
##########
File path: pom.xml
##########
@@ -2045,40 +2005,6 @@ under the License.
<enabled>true</enabled>
</releases>
</repository>
-
- <!-- Disable some Spring repositories pulled in by dependencies - see
Review comment:
Isn't the information provided in the [given
link](https://spring.io/blog/2020/10/29/notice-of-permissions-changes-to-repo-spring-io-fall-and-winter-2020)
still valid?
##########
File path: pom.xml
##########
@@ -2045,40 +2005,6 @@ under the License.
<enabled>true</enabled>
</releases>
</repository>
-
- <!-- Disable some Spring repositories pulled in by dependencies - see
Review comment:
When you remove such disabled repo definitions, you will notice that
some 3rd party dependencies will be attempted to be downloaded from Spring
repositories, failing with permission errors.
Anyway, let's keep the repo removal, I am going to build from your branch to
see if I can still see such errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
