mmoayyed commented on a change in pull request #296:
URL: https://github.com/apache/syncope/pull/296#discussion_r765529126



##########
File path: client/idrepo/console/pom.xml
##########
@@ -124,7 +124,7 @@ under the License.
     </dependency>
     <dependency>
       <groupId>org.apache.logging.log4j</groupId>
-      <artifactId>log4j-slf4j18-impl</artifactId>
+      <artifactId>log4j-slf4j-impl</artifactId>

Review comment:
       (Copying the answer here as well so it's available for the public)
   
   > This is to mainly to align with CAS, and to also align with the now-stable 
slf4j version, to avoid these:
   
   ```
   java.lang.ClassCastException: class org.slf4j.helpers.NOPLoggerFactory 
cannot be cast to class 
   org.apache.logging.slf4j.Log4jLoggerFactory 
(org.slf4j.helpers.NOPLoggerFactory and 
   org.apache.logging.slf4j.Log4jLoggerFactory are in unnamed module of loader 
   org.springframework.boot.loader.LaunchedURLClassLoader
   ```
   
   Ref: https://github.com/apereo/cas/pull/5261
   Ref: https://github.com/apereo/cas/pull/5264




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to