ilgrosso commented on a change in pull request #302:
URL: https://github.com/apache/syncope/pull/302#discussion_r784806538
##########
File path:
fit/core-reference/src/test/java/org/apache/syncope/fit/AbstractITCase.java
##########
@@ -702,4 +767,9 @@ protected void removeLdapRemoteObject(
} while (results.isEmpty() && i < maxWaitSeconds);
return results;
}
+
+ protected void cleanUpRemediations() {
Review comment:
This method seems to be used only within `PullTaskITCase`: can you move
it to that class?
##########
File path:
fit/core-reference/src/test/java/org/apache/syncope/fit/AbstractITCase.java
##########
@@ -635,6 +668,38 @@ protected void updateLdapRemoteObject(
}
}
+ protected Pair<String, Set<Attribute>> prepareLdapAttributes(
Review comment:
This method is used only by a single test, please move it back to the
containing test class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
