ilgrosso commented on a change in pull request #304:
URL: https://github.com/apache/syncope/pull/304#discussion_r795666973
##########
File path: core/logic/src/main/java/org/apache/syncope/core/logic/TaskLogic.java
##########
@@ -188,9 +189,9 @@
type, resourceDAO.find(resource),
notificationDAO.find(notification), anyTypeKind, entityKey);
List<T> result = taskDAO.findAll(
- type, resourceDAO.find(resource),
notificationDAO.find(notification), anyTypeKind, entityKey,
- page, size, orderByClauses).stream().
- <T>map(task -> binder.getTaskTO(task,
taskUtilsFactory.getInstance(type), details)).
+ type, resourceDAO.find(resource),
notificationDAO.find(notification), anyTypeKind, entityKey,
Review comment:
Please revert this formatting-only change
##########
File path:
core/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/TaskServiceImpl.java
##########
@@ -96,11 +96,11 @@ public void update(final TaskType type, final SchedTaskTO
taskTO) {
}
@Override
- public Response purgePropagations(final Date since, final List<ExecStatus>
statuses) {
+ public Response purgePropagations(final Date since, final List<ExecStatus>
statuses, final List<String> resources) {
if (since == null && CollectionUtils.isEmpty(statuses)) {
Review comment:
This condition should be updated as
```if (since == null && CollectionUtils.isEmpty(statuses) &&
CollectionUtils.isEmpty(resources)) {```
##########
File path: core/logic/src/main/java/org/apache/syncope/core/logic/TaskLogic.java
##########
@@ -454,8 +455,12 @@ public void actionJob(final String key, final JobAction
action) {
}
@PreAuthorize("hasRole('" + StandardEntitlement.TASK_DELETE + "')")
- public List<PropagationTaskTO> purgePropagations(final Date since, final
List<ExecStatus> statuses) {
- return taskDAO.purgePropagations(since, statuses);
+ public List<PropagationTaskTO> purgePropagations(
+ final Date since,
+ final List<ExecStatus> statuses,
+ final List<String> resources) {
Review comment:
What happens if `resources` is `null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
