ilgrosso commented on a change in pull request #316:
URL: https://github.com/apache/syncope/pull/316#discussion_r808295939
##########
File path:
client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/SchedTaskDirectoryPanel.java
##########
@@ -156,15 +213,15 @@ protected Serializable onApplyInternal(
Constants.NAME_FIELD_NAME, Constants.NAME_FIELD_NAME));
columns.add(new PropertyColumn<>(
- new StringResourceModel("jobDelegate", this), "jobDelegate",
"jobDelegate") {
+ new StringResourceModel("jobDelegate", this), "jobDelegate",
"jobDelegate") {
private static final long serialVersionUID = -3223917055078733093L;
@Override
public void populateItem(
- final Item<ICellPopulator<T>> item,
- final String componentId,
- final IModel<T> rowModel) {
+ final Item<ICellPopulator<T>> item,
Review comment:
Please revert all these formatting-only changes
##########
File path:
client/idrepo/console/src/main/java/org/apache/syncope/client/console/widgets/CompletenessWidget.java
##########
@@ -79,7 +79,7 @@ public CompletenessWidget(final String id, final Map<String,
Boolean> confComple
actions.add(policies);
policies.setVisible(
!confCompleteness.get(NumbersInfo.ConfItem.ACCOUNT_POLICY.name())
- ||
!confCompleteness.get(NumbersInfo.ConfItem.PASSWORD_POLICY.name()));
+ ||
!confCompleteness.get(NumbersInfo.ConfItem.PASSWORD_POLICY.name()));
Review comment:
Please revert these formatting-only changes
##########
File path:
client/idrepo/console/src/main/resources/org/apache/syncope/client/console/wicket/markup/html/form/ActionsPanel.html
##########
@@ -6,9 +6,7 @@
to you under the Apache License, Version 2.0 (the
Review comment:
You don't seem to have actually made a change to this file, please revert
##########
File path:
client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/BasePage.java
##########
@@ -122,12 +122,12 @@ public BasePage(final PageParameters parameters) {
public void onClick() {
try {
HttpResourceStream stream = new HttpResourceStream(
- new
ResponseHolder(SyncopeRestClient.exportInternalStorageContent()));
+ new
ResponseHolder(SyncopeRestClient.exportInternalStorageContent()));
Review comment:
Please revert all such formatting-only changes
##########
File path:
client/idrepo/console/src/main/java/org/apache/syncope/client/console/wizards/WizardMgtPanel.java
##########
@@ -228,12 +228,12 @@ public void onEvent(final IEvent<?> event) {
} else if (event.getPayload() instanceof
AjaxWizard.NewItemFinishEvent) {
SyncopeConsoleSession.get().success(getString(Constants.OPERATION_SUCCEEDED));
target.ifPresent(ajaxRequestTarget ->
- ((BaseWebPage)
pageRef.getPage()).getNotificationPanel().refresh(ajaxRequestTarget));
+ ((BaseWebPage)
pageRef.getPage()).getNotificationPanel().refresh(ajaxRequestTarget));
Review comment:
Please revert these formatting-only changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
