andrea-patricelli commented on a change in pull request #319:
URL: https://github.com/apache/syncope/pull/319#discussion_r818461666
##########
File path:
core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/user/User.java
##########
@@ -54,8 +55,14 @@
void setSecurityQuestion(SecurityQuestion securityQuestion);
String getSecurityAnswer();
+
+ String getClearSecurityAnswer();
- void setSecurityAnswer(String securityAnswer);
+ void setEncodedSecurityAnswer(String securityAnswer);
+
+ void setSecurityAnswer(String securityAnswer, CipherAlgorithm
cipherAlgoritm);
Review comment:
I've noticed that disallowing setting cipher algorithm once set could
impact cases like the one in this test
https://github.com/apache/syncope/blob/2_1_X/core/provisioning-java/src/test/java/org/apache/syncope/core/provisioning/java/MappingManagerImplTest.java#L61-L132
Could it be too much restrictive? That is not so usual situation, but could
lead to errors if for some reason an admin decides to change password hashing
algorithm, with all its consequences...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
