ilgrosso commented on code in PR #363: URL: https://github.com/apache/syncope/pull/363#discussion_r928199986
########## client/idrepo/enduser/src/main/resources/org/apache/syncope/client/enduser/SyncopeEnduserApplication.properties: ########## @@ -78,6 +78,7 @@ before=Before after=After captcha_error=Captcha entered does not match +blank_security_info=Security question and/or answer is/are blank Review Comment: Is this key not needed in other languages? ########## client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/commons/RESTUtils.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.syncope.client.enduser.commons; + +import org.apache.syncope.client.enduser.rest.UserSelfRestClient; +import org.apache.syncope.common.lib.request.UserCR; +import org.apache.syncope.common.lib.request.UserUR; +import org.apache.syncope.common.lib.to.ProvisioningResult; +import org.apache.syncope.common.lib.to.UserTO; + +public final class RESTUtils { Review Comment: This class seems to be some sort of handler for `ProvisioningResult`, please name it accordingly, ########## client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/commons/PageParametersUtils.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.syncope.client.enduser.commons; + +import java.util.List; +import java.util.stream.Collectors; +import org.apache.syncope.client.enduser.SyncopeWebApplication; +import org.apache.syncope.client.enduser.pages.Dashboard; +import org.apache.syncope.client.ui.commons.Constants; +import org.apache.syncope.common.lib.to.PropagationStatus; +import org.apache.wicket.Component; +import org.apache.wicket.request.mapper.parameter.PageParameters; + +public final class PageParametersUtils { Review Comment: This seems to be related only to propagation, please merge it with class below. ########## client/idrepo/enduser/src/main/resources/org/apache/syncope/client/enduser/pages/SelfResult_ja.properties: ########## @@ -14,4 +14,6 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -login=Back to Home +login=???? Review Comment: Are those real question marks? ########## client/idrepo/enduser/src/main/resources/org/apache/syncope/client/enduser/pages/SelfResult_ru.properties: ########## @@ -14,4 +14,6 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -login=Back to Home +login=????????? ????? Review Comment: Are those real question marks? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
