github-code-scanning[bot] commented on code in PR #374:
URL: https://github.com/apache/syncope/pull/374#discussion_r963854270
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/propagation/PropagationActions.java:
##########
@@ -67,7 +68,7 @@
* @param execution execution result
* @param error propagation error
*/
- default void onError(PropagationTaskInfo taskInfo, TaskExec execution,
Exception error) {
+ default void onError(PropagationTaskInfo taskInfo,
TaskExec<PropagationTask> execution, Exception error) {
Review Comment:
## Useless parameter
The parameter taskInfo is unused.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1153)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/propagation/PropagationActions.java:
##########
@@ -67,7 +68,7 @@
* @param execution execution result
* @param error propagation error
*/
- default void onError(PropagationTaskInfo taskInfo, TaskExec execution,
Exception error) {
+ default void onError(PropagationTaskInfo taskInfo,
TaskExec<PropagationTask> execution, Exception error) {
Review Comment:
## Useless parameter
The parameter execution is unused.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1154)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/propagation/PropagationActions.java:
##########
@@ -78,7 +79,7 @@
* @param execution execution result
* @param afterObj connector object read after propagation
*/
- default void after(PropagationTaskInfo taskInfo, TaskExec execution,
ConnectorObject afterObj) {
+ default void after(PropagationTaskInfo taskInfo, TaskExec<PropagationTask>
execution, ConnectorObject afterObj) {
Review Comment:
## Useless parameter
The parameter afterObj is unused.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1152)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/propagation/PropagationActions.java:
##########
@@ -78,7 +79,7 @@
* @param execution execution result
* @param afterObj connector object read after propagation
*/
- default void after(PropagationTaskInfo taskInfo, TaskExec execution,
ConnectorObject afterObj) {
+ default void after(PropagationTaskInfo taskInfo, TaskExec<PropagationTask>
execution, ConnectorObject afterObj) {
Review Comment:
## Useless parameter
The parameter taskInfo is unused.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1150)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/propagation/PropagationActions.java:
##########
@@ -67,7 +68,7 @@
* @param execution execution result
* @param error propagation error
*/
- default void onError(PropagationTaskInfo taskInfo, TaskExec execution,
Exception error) {
+ default void onError(PropagationTaskInfo taskInfo,
TaskExec<PropagationTask> execution, Exception error) {
Review Comment:
## Useless parameter
The parameter error is unused.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1155)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/propagation/PropagationActions.java:
##########
@@ -78,7 +79,7 @@
* @param execution execution result
* @param afterObj connector object read after propagation
*/
- default void after(PropagationTaskInfo taskInfo, TaskExec execution,
ConnectorObject afterObj) {
+ default void after(PropagationTaskInfo taskInfo, TaskExec<PropagationTask>
execution, ConnectorObject afterObj) {
Review Comment:
## Useless parameter
The parameter execution is unused.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1151)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
