ilgrosso commented on code in PR #377:
URL: https://github.com/apache/syncope/pull/377#discussion_r982238298
##########
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/ResourceDataBinderImpl.java:
##########
@@ -518,21 +519,21 @@ protected void populateMapping(
invalidMapping.getElements().add(
"Only " + MappingPurpose.PROPAGATION.name()
- + " allowed when referring to groups");
+ + " allowed when referring to
groups");
}
if (intAttrName.getRelatedAnyObject() != null
&& item.getPurpose() !=
MappingPurpose.PROPAGATION) {
invalidMapping.getElements().add(
"Only " + MappingPurpose.PROPAGATION.name()
- + " allowed when referring to any
objects");
+ + " allowed when referring to any
objects");
}
if (intAttrName.getPrivilegesOfApplication() != null
&& item.getPurpose() !=
MappingPurpose.PROPAGATION) {
invalidMapping.getElements().add(
"Only " + MappingPurpose.PROPAGATION.name()
- + " allowed when referring to privileges");
+ + " allowed when referring to
privileges");
Review Comment:
formatting change
##########
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/ResourceDataBinderImpl.java:
##########
@@ -518,21 +519,21 @@ protected void populateMapping(
invalidMapping.getElements().add(
"Only " + MappingPurpose.PROPAGATION.name()
- + " allowed when referring to groups");
+ + " allowed when referring to
groups");
}
if (intAttrName.getRelatedAnyObject() != null
&& item.getPurpose() !=
MappingPurpose.PROPAGATION) {
invalidMapping.getElements().add(
"Only " + MappingPurpose.PROPAGATION.name()
- + " allowed when referring to any
objects");
+ + " allowed when referring to any
objects");
Review Comment:
formatting change
##########
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/ResourceDataBinderImpl.java:
##########
@@ -697,4 +698,4 @@ public ResourceTO getResourceTO(final ExternalResource
resource) {
return resourceTO;
}
-}
+}
Review Comment:
formatting change
##########
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/ResourceDataBinderImpl.java:
##########
@@ -639,10 +640,10 @@ public ResourceTO getResourceTO(final ExternalResource
resource) {
});
resourceTO.getProvisions().
forEach(provisionTO -> virSchemaDAO.find(resource.getKey(),
provisionTO.getAnyType()).
- forEach(virSchema -> {
- provisionTO.getVirSchemas().add(virSchema.getKey());
-
provisionTO.getMapping().getLinkingItems().add(virSchema.asLinkingMappingItem());
- }));
+ forEach(virSchema -> {
Review Comment:
formatting change
##########
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/ResourceDataBinderImpl.java:
##########
@@ -557,15 +558,15 @@ protected void populateMapping(
invalidMapping.getElements().add(
"Only " + MappingPurpose.PROPAGATION.name()
- + " allowed when referring to users");
+ + " allowed when referring to
users");
}
if ((intAttrName.getRelationshipType() != null
|| intAttrName.getRelationshipAnyType() !=
null)
&& item.getPurpose() !=
MappingPurpose.PROPAGATION) {
invalidMapping.getElements().add(
"Only " + MappingPurpose.PROPAGATION.name()
- + " allowed when referring to
relationships");
+ + " allowed when referring to
relationships");
Review Comment:
formatting change
##########
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/ResourceDataBinderImpl.java:
##########
@@ -557,15 +558,15 @@ protected void populateMapping(
invalidMapping.getElements().add(
"Only " + MappingPurpose.PROPAGATION.name()
- + " allowed when referring to users");
+ + " allowed when referring to
users");
Review Comment:
formatting change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
